Skip to content
This repository has been archived by the owner on May 7, 2020. It is now read-only.

[Astro] added support for duplicate identification to avoid unnecessary discovery results #4611

Merged
merged 2 commits into from Nov 24, 2017

Conversation

kaikreuzer
Copy link
Contributor

Signed-off-by: Kai Kreuzer kai@openhab.org

…very results

Signed-off-by: Kai Kreuzer <kai@openhab.org>
Copy link
Contributor

@maggu2810 maggu2810 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments about indentation style.

@@ -26,6 +26,9 @@
<channel-group id="position" typeId="position" />
<channel-group id="zodiac" typeId="moonZodiac" />
</channel-groups>

<representation-property>geolocation</representation-property>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the formatter change spaces to tabs?

@@ -54,6 +54,9 @@
<channel-group id="eclipse" typeId="sunEclipse" />
<channel-group id="phase" typeId="sunPhase" />
</channel-groups>

<representation-property>geolocation</representation-property>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

Signed-off-by: Kai Kreuzer <kai@openhab.org>
@kaikreuzer
Copy link
Contributor Author

Thanks, fixed.

@sjsf sjsf merged commit 31911b1 into eclipse-archived:master Nov 24, 2017
@kaikreuzer kaikreuzer deleted the astrorep branch November 24, 2017 15:36
@kaikreuzer kaikreuzer added this to the 0.9.0 milestone Nov 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants