Skip to content
This repository has been archived by the owner on May 7, 2020. It is now read-only.

point to groovy-eclipse release repository directly #4858

Merged
merged 1 commit into from Jan 6, 2018

Conversation

sjsf
Copy link
Contributor

@sjsf sjsf commented Jan 5, 2018

...instead of using the composite repository URL which they
apparently do not intend to keep stable.

Content stays the same, hence no versions change anywhere,
therefore no surprises expected ;-)

see groovy/groovy-eclipse#406

Signed-off-by: Simon Kaufmann simon.kfm@googlemail.com

...instead of using the composite repository URL which they
apparently do not intend to keep stable.

Content stays the same, hence no versions change anywhere,
therefore no surprises expected ;-)

see groovy/groovy-eclipse#406

Signed-off-by: Simon Kaufmann <simon.kfm@googlemail.com>
@kaikreuzer
Copy link
Contributor

Thanks, let's hope that this is a stable one!

@kaikreuzer kaikreuzer merged commit 5c24c0b into eclipse-archived:master Jan 6, 2018
@lolodomo
Copy link
Contributor

lolodomo commented Jan 6, 2018

I can confirm that with your fix, it is possible again to build ESH with Maven.

To be exact, I have as usual to disable the tests and unfortunately the build finally failed in Paper UI:

[INFO] --- frontend-maven-plugin:1.0:npm (npm install) @ org.eclipse.smarthome.ui.paper ---
[INFO] Running 'npm install' in D:\dev\openhab2\git\smarthome\extensions\ui\org.eclipse.smarthome.ui.paper
[ERROR] npm ERR! code MODULE_NOT_FOUND
[ERROR] npm ERR! Cannot find module 'internal/fs'
[ERROR]
[ERROR] npm ERR! A complete log of this run can be found in:
[ERROR] npm ERR!     D:\dev\openhab2\git\smarthome\extensions\ui\org.eclipse.smarthome.ui.paper\npm_cache\_logs\2018-01-06T11_48_46_683Z-debug.log

But of course your fix is OK and necessary as without it we can even not start the build.

@lolodomo
Copy link
Contributor

lolodomo commented Jan 6, 2018

I will open a separate issue for the problem with Paper UI build.
I am running the build on the master branch.

dgajic pushed a commit to dgajic/smarthome that referenced this pull request Jan 27, 2018
…#4858)

...instead of using the composite repository URL which they
apparently do not intend to keep stable.

Content stays the same, hence no versions change anywhere,
therefore no surprises expected ;-)

see groovy/groovy-eclipse#406

Signed-off-by: Simon Kaufmann <simon.kfm@googlemail.com>
@htreu htreu added this to the 0.10.0 milestone Oct 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants