Skip to content
This repository has been archived by the owner on May 7, 2020. It is now read-only.

Bug #482188 modification : #520

Merged
merged 1 commit into from
Nov 17, 2015
Merged

Conversation

clinique
Copy link
Contributor

  • LocationItem delegates distanceFrom calculation to PointType
  • Moving distanceFrom calculation details in PointType
  • Enhancing PointType constructor as in PR add measurement feature to target platform #3410 of OH1
  • Splitted tests between respectives tests classes for LocationItem and PointType

Signed-off-by: Gaël L'hopital glhopital@gmail.com

- LocationItem delegates distanceFrom calculation to PointType
- Moving distanceFrom calculation details in PointType
- Enhancing PointType constructor as in PR #3410 of OH1
- Splitted tests between respectives tests classes for LocationItem and PointType

Signed-off-by: Gaël L'hopital <glhopital@gmail.com>
@eclipsewebmaster
Copy link
Contributor

Issue tracker reference:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=482188

@dnobel
Copy link
Contributor

dnobel commented Nov 16, 2015

@kaikreuzer Why does mentioning a bug with a hash "#482188" creates a reference the the bug tracker, but not if you do it like proposed from our process with a "Bug: 482188" line (https://www.eclipse.org/smarthome/documentation/community/contributing.html#conventions-for-pull-requests) . Do we have to adapt the documentation?

@kaikreuzer
Copy link
Contributor

@dnobel This is the official reference: https://wiki.eclipse.org/Development_Resources/Contributing_via_Git#The_Commit_Record
The Bugzilla ref therefore has to be an url and not any of the two options you mention :-)

@dnobel
Copy link
Contributor

dnobel commented Nov 16, 2015

OK, but the commit message in this PR does not contain a URL, or? So how did the github hook get the bug reference?

@dnobel
Copy link
Contributor

dnobel commented Nov 16, 2015

maybe @eclipsewebmaster can help here :)

@kaikreuzer
Copy link
Contributor

lgtm, thanks!

kaikreuzer added a commit that referenced this pull request Nov 17, 2015
@kaikreuzer kaikreuzer merged commit b6c44e4 into eclipse-archived:master Nov 17, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants