This repository has been archived by the owner on May 7, 2020. It is now read-only.
config/core/Configuration: Convert not only BigDecimal but also Strings to Number objects if required #5262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gs to Number objects if required Signed-off-by: David Graeff <david.graeff@web.de>
htreu
approved these changes
Mar 20, 2018
There was a problem hiding this comment.
Yes, I agree. LGTM.
Unfortunately I don't have merge power yet. Please merge @maggu2810, thanks.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some time ago numbers in service configuration maps were dispatched as BigDecimal objects only.
Now they are Strings instead. Because config/core/Configuration is used for parsing service configuration key/values which naturally use number types as well, the conversion should work for Strings to Float,Integer,Double as well.
Signed-off-by: David Graeff david.graeff@web.de