add missing presence-on icon #5566
Conversation
fixes eclipse-archived#5416 Signed-off-by: Simon Kaufmann <simon.kfm@googlemail.com>
There was a problem hiding this comment.
Imho, we should not duplicate the maintenance of icons and "presence-on" is identical to "presence".
Note that we so far handle that by creating copies for the uninitialized version. So imho, we should consider the "presence-on" to be the main icon and have it copied to "presence" in the script (as the copies are committed to the repo as well, the only change in this PR will be the addition in the script, I guess).
|
And again I learned something new... |
Signed-off-by: Simon Kaufmann <simon.kfm@googlemail.com>
Hm, I missed that you omitted that part - I've created #5575 to fix that. |
|
Ouch, indeed, I overlooked that instruction. Having a script to copy files once which then will be checked-in apparently is so weird that my brain neglected to acknowledge this piece of information... |
* add missing presence-on icon fixes eclipse-archived#5416 Signed-off-by: Simon Kaufmann <simon.kfm@googlemail.com>
...as there previously was a
presenceandpresence-officon, but nopresence-onicon.fixes #5416
Signed-off-by: Simon Kaufmann simon.kfm@googlemail.com