Skip to content
This repository has been archived by the owner on May 7, 2020. It is now read-only.

json response: use status type interface instead of a specific impl. #5650

Merged
merged 1 commit into from May 30, 2018
Merged

json response: use status type interface instead of a specific impl. #5650

merged 1 commit into from May 30, 2018

Conversation

maggu2810
Copy link
Contributor

No description provided.

Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
Copy link
Contributor

@htreu htreu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I restarted Travis, lets wait for its approval.

@htreu
Copy link
Contributor

htreu commented May 30, 2018

Travis seems to fail unrelated with [ERROR] The constructor HueBridge(String) is undefined.

@lolodomo
Copy link
Contributor

Id this not API breaking ? No impact on existing code ?

@htreu
Copy link
Contributor

htreu commented May 30, 2018

It should not break anything. Response.StatusType is the interface to Response.Status so every existing call is compatible.

@htreu htreu merged commit a5cb9a1 into eclipse-archived:master May 30, 2018
@maggu2810 maggu2810 deleted the rest-json-status branch May 30, 2018 09:20
ermartens pushed a commit to ermartens/smarthome that referenced this pull request Jun 15, 2018
@htreu htreu added this to the 0.10.0 milestone Oct 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants