This repository has been archived by the owner on May 7, 2020. It is now read-only.
[automation] refactor OSGi DS to annotation, change to lazy activation #6284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes eclipse-archived#6149. Signed-off-by: Henning Treu <henning.treu@telekom.de>
kaikreuzer
approved these changes
Sep 27, 2018
kaikreuzer
approved these changes
Sep 27, 2018
There was a problem hiding this comment.
Thanks - a huge improvement to get rid off those static methods and calls!
@smerschjohann, @lewie and others: If we are missing something and those static calls were by intention, please shout! But from the code and all tests, it seems to be just fine to make it all proper services.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6149.
Signed-off-by: Henning Treu henning.treu@telekom.de