Skip to content
This repository has been archived by the owner on May 7, 2020. It is now read-only.

drop most usage of Guava's com.google.common package #6449

Merged
merged 16 commits into from Nov 5, 2018
Merged

drop most usage of Guava's com.google.common package #6449

merged 16 commits into from Nov 5, 2018

Conversation

maggu2810
Copy link
Contributor

@maggu2810 maggu2810 commented Nov 4, 2018

This drops the most usage of com.google.common.

The model bundle has been kept untouched as Xtext itself needs Guava and generates code that uses it.

The other remaining usages (all can be done in another PR and should not block this cleanup):

bundle (esh) class Guava (collect) note
io.rest.sitemap SitemapResource.java MapMaker It uses some weak reference related stuff. @kaikreuzer AFAIK this has been introduced by you. Correct? Can you come up with some other suggestion?
config.discovery DiscoveryServiceRegistryImpl HashMultimap
core.thing ThingManagerImpl HashMultimap
core.thing ThingManagerImpl Multimaps
core.thing ThingManagerImpl SetMultimap

Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
@kaikreuzer
Copy link
Contributor

Can you come up with some other suggestion?

The MapMaker is pretty convenient, so not completely easy to replace it. Asking SO, https://stackoverflow.com/a/33703220 might be the best alternative, wdyt?

Copy link
Contributor

@htreu htreu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I suggest merging this and postpone the replacement of MapMaker to a separate PR. I will create an issue for follow up.

@maggu2810
Copy link
Contributor Author

I suggest merging this and postpone the replacement of MapMaker to a separate PR

Me, too

The other remaining usages (all can be done in another PR and should not block this cleanup):

@htreu htreu mentioned this pull request Nov 5, 2018
@htreu
Copy link
Contributor

htreu commented Nov 5, 2018

Replace MapMaker issue: #6460

@htreu htreu merged commit a0e1788 into eclipse-archived:master Nov 5, 2018
@maggu2810 maggu2810 deleted the guava branch November 5, 2018 15:32
@kaikreuzer kaikreuzer added this to the 0.10.0 milestone Dec 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants