This repository has been archived by the owner on May 7, 2020. It is now read-only.
MQTT: Add MQTT receive tests for all channel types #6664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TypeParser commit a few days ago allowed to send command strings like INCREASE/DECREASE. Unfortunately it broke a few channels. * This commit adds tests for all channel types. * The RGB color channel was broken (even before the TypeParser commit): Fixed. Added features: * Add location, datetime and image channel types including tests and readme sections. Refactor: * The internal.values.* classes are a lot slimmer. Value itself is not an interface but an abstract class now. * Move the xml thing/channel configurations to ESH-INF/config. * Rename two methods for clarity, so that value.getValue().getValue() is not a think anymore. Signed-off-by: David Gräff <david.graeff@web.de>
davidgraeff
force-pushed
the
mqttvalues
branch
from
89df1b3
to
f1305e3
Compare
kaikreuzer
approved these changes
Dec 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TypeParser commit a few days ago allowed to send command strings
like INCREASE/DECREASE. Unfortunately it broke a few channels.
Added features:
tests and readme sections.
Refactor:
is not an interface but an abstract class now.
is not a think anymore.
Signed-off-by: David Gräff david.graeff@web.de