Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print warning when declaring annotations with SOURCE retention via ITD #201

Open
kriegaex opened this issue Dec 21, 2022 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@kriegaex
Copy link
Contributor

This is a follow-up issue for PR #196 and Bugzilla bug 366085.

The imperfect workaround for that bug simply ignores declared source-level annotations occurring in the AST. The better way to solve this problem would be to eliminate them from the AST when parsing the aspect at some point after the corresponding annotation type has been resolved and its retention level can be determined with certainty. In each case, a comprehensive weaver or compiler warning should be issued and the AST cleaned up (or not polluted in the first place, whichever method is applicable).

@aclement, like I said, I would need your guidance in order to fix this problem properly, which is why for now I shall leave it at merging the workaround.

@kriegaex kriegaex added the enhancement New feature or request label Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant