Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review/port performance enhancements proposed in bugzilla issue #9

Closed
aclement opened this issue Aug 14, 2020 · 6 comments
Closed

Review/port performance enhancements proposed in bugzilla issue #9

aclement opened this issue Aug 14, 2020 · 6 comments
Labels
enhancement New feature or request
Milestone

Comments

@aclement
Copy link
Contributor

See https://bugs.eclipse.org/bugs/show_bug.cgi?id=565450 which includes the patch.

@LifeIsStrange
Copy link

Any update? This seems like a potentially big improvement

@aclement
Copy link
Contributor Author

aclement commented Feb 9, 2021

Unfortunately haven't had time to do it, but if someone wants to turn it into a PR with maybe a system property to control the behaviour, that would be a likely way for it to go in with limited testing (so by default you get todays behaviour, but switch on a property and this feature could be tested out).

@kriegaex
Copy link
Contributor

Because the commits were directly on master and do not come from PR #37, let me mention for reference that @aclement added these changes: 1b3cead...3227aad which are probably going to superseed the PR and eventuall close this issue. Andy was also so kind to add basic tests. 😊

@kriegaex
Copy link
Contributor

To do: Mention the new options in the 1.9.8 release notes and wherever else it might make sense to integrate them into existing documentation.

@aclement
Copy link
Contributor Author

I think yes to release notes, obviously, but also it needs its own post on the mailing list to raise awareness for anyone that wants to try this out and see if it helps them. I'm not sure where else we could publicize it - my AspectJ blog is rather long in the tooth now.

@kriegaex
Copy link
Contributor

@aclement: Release notes done, see #116.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants