-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/multiple datasinks #308
Feature/multiple datasinks #308
Conversation
Signed-off-by: Jannis Jung <jannis.jung@iese.fraunhofer.de>
Signed-off-by: Jannis Jung <jannis.jung@iese.fraunhofer.de>
Signed-off-by: Jannis Jung <jannis.jung@iese.fraunhofer.de>
…echanic for Datasink-to-Transformer-Mapping Signed-off-by: Jannis Jung <jannis.jung@iese.fraunhofer.de>
…ables Usage of new datasinkMappingConfiguration attribute * Adds Examples for handling all data transformation equally per datasink * Adds Examples for handling data transformation individually per datasink Signed-off-by: Jannis Jung <jannis.jung@iese.fraunhofer.de>
...g/eclipse/digitaltwin/basyx/databridge/core/configuration/route/core/RouteConfiguration.java
Show resolved
Hide resolved
...g/eclipse/digitaltwin/basyx/databridge/core/configuration/route/core/RouteCreatorHelper.java
Show resolved
Hide resolved
...g/eclipse/digitaltwin/basyx/databridge/core/configuration/route/core/RouteCreatorHelper.java
Show resolved
Hide resolved
...g/eclipse/digitaltwin/basyx/databridge/core/configuration/route/core/RouteCreatorHelper.java
Outdated
Show resolved
Hide resolved
...g/eclipse/digitaltwin/basyx/databridge/core/configuration/route/event/EventRouteCreator.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert cosmetic changes
|
||
client.close(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please readd this to close the client
databridge.examples/databridge.examples.kafka-jsonata-aas/pom.xml
Outdated
Show resolved
Hide resolved
databridge.examples/databridge.examples.kafka-jsonatamultiple-aas/pom.xml
Outdated
Show resolved
Hide resolved
...lipse/digitaltwin/basyx/databridge/examples/kafkajsonatamultipleaas/test/TestAASUpdater.java
Show resolved
Hide resolved
Signed-off-by: Jannis Jung <jannis.jung@iese.fraunhofer.de>
…sjung/basyx-databridge into feature/multiple-datasinks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍🏻
The only thing I don't agree with are the cosmetic changes (even tho we have the BaSyx formatter).
For that I am referring to our code of conduct:
https://github.com/eclipse-basyx/basyx-applications/blob/main/.github/CONTRIBUTING.md#did-you-fix-whitespace-format-code-or-make-a-purely-cosmetic-patch
Signed-off-by: Jannis Jung <jannis.jung@iese.fraunhofer.de>
Signed-off-by: Jannis Jung <jannis.jung@iese.fraunhofer.de>
Signed-off-by: Jannis Jung <jannis.jung@iese.fraunhofer.de>
Signed-off-by: Jannis Jung <jannis.jung@iese.fraunhofer.de>
Signed-off-by: Jannis Jung <jannis.jung@iese.fraunhofer.de>
Signed-off-by: Jannis Jung <jannis.jung@iese.fraunhofer.de>
Signed-off-by: Jannis Jung <jannis.jung@iese.fraunhofer.de>
Signed-off-by: Jannis Jung <jannis.jung@iese.fraunhofer.de>
Signed-off-by: Jannis Jung <jannis.jung@iese.fraunhofer.de>
Signed-off-by: Jannis Jung <jannis.jung@iese.fraunhofer.de>
...va/org/eclipse/digitaltwin/basyx/databridge/examples/aasjsonatamqtt/test/TestAASUpdater.java
Outdated
Show resolved
Hide resolved
...va/org/eclipse/digitaltwin/basyx/databridge/examples/aasjsonatamqtt/test/TestAASUpdater.java
Show resolved
Hide resolved
...a/org/eclipse/digitaltwin/basyx/databridge/examples/kafkajsonataaas/test/TestAASUpdater.java
Outdated
Show resolved
Hide resolved
.../digitaltwin/basyx/databridge/executable/integration/ITTestDataBridgeAASPollingConsumer.java
Show resolved
Hide resolved
...pse/digitaltwin/basyx/databridge/executable/regression/TestDataBridgeAASPollingConsumer.java
Show resolved
Hide resolved
...pse/digitaltwin/basyx/databridge/executable/regression/TestDataBridgeAASPollingConsumer.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jannis Jung <jannis.jung@iese.fraunhofer.de>
Signed-off-by: Jannis Jung <jannis.jung@iese.fraunhofer.de>
Signed-off-by: Jannis Jung <jannis.jung@iese.fraunhofer.de>
…sjung/basyx-databridge into feature/multiple-datasinks
Signed-off-by: Jannis Jung <jannis.jung@iese.fraunhofer.de>
Signed-off-by: Jannis Jung <jannis.jung@iese.fraunhofer.de>
This PR is built upon PR #300 Adds support for multiple datasinks in one route
Userstory:
As a data integrator
I want to integrate a single datasource with multiple properties
so that I can break down complex data objects into single SMEs
Rules:
Changes
datasinkMappingConfiguration
to routes.jsonExample Configuration: