Implements authorization for ConnectedAasManager #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implements authorization for ConnectedAasRepository - Implements authorization for ConnectedAasService - Implements authorization for ConnectedSubmodelRepository - Implements authorization for ConnectedSubmodelService Signed-off-by: Mohammad Ghazanfar Ali Danish <ghazanfar.danish@iese.fraunhofer.de>
Signed-off-by: Mohammad Ghazanfar Ali Danish <ghazanfar.danish@iese.fraunhofer.de>
Signed-off-by: Mohammad Ghazanfar Ali Danish <ghazanfar.danish@iese.fraunhofer.de>
Signed-off-by: Mohammad Ghazanfar Ali Danish <ghazanfar.danish@iese.fraunhofer.de>
Signed-off-by: Mohammad Ghazanfar Ali Danish <ghazanfar.danish@iese.fraunhofer.de>
Signed-off-by: Mohammad Ghazanfar Ali Danish <ghazanfar.danish@iese.fraunhofer.de>
Signed-off-by: Mohammad Ghazanfar Ali Danish <ghazanfar.danish@iese.fraunhofer.de>
Signed-off-by: Mohammad Ghazanfar Ali Danish <ghazanfar.danish@iese.fraunhofer.de>
Signed-off-by: Mohammad Ghazanfar Ali Danish <ghazanfar.danish@iese.fraunhofer.de>
Signed-off-by: Mohammad Ghazanfar Ali Danish <ghazanfar.danish@iese.fraunhofer.de>
Signed-off-by: Mohammad Ghazanfar Ali Danish <ghazanfar.danish@iese.fraunhofer.de>
Signed-off-by: Mohammad Ghazanfar Ali Danish <ghazanfar.danish@iese.fraunhofer.de>
mateusmolina-iese
suggested changes
Jun 10, 2024
ci/docker-compose.yml
Outdated
| image: eclipsebasyx/keycloak:0.0.1 | ||
| build: | ||
| context: ./../examples/keycloak | ||
| dockerfile_inline: | |
There was a problem hiding this comment.
External dockerfile?
| import org.keycloak.provider.Spi; | ||
|
|
||
| @AutoService(Spi.class) | ||
| public class InitializerSpi implements Spi { |
There was a problem hiding this comment.
Move to CI, since it's a CI plugin (not example)
| <plugins> | ||
| <plugin> |
There was a problem hiding this comment.
Is it necessary?
There was a problem hiding this comment.
Can you please add a test to the release-mongodb (for the log sink)
| @Test | ||
| @Override | ||
| public void whenPostSubmodelDescriptor_LocationIsReturned() throws ApiException, IOException { | ||
| // TODO: It uses normal GET unauthorized request, need to override and refactor |
There was a problem hiding this comment.
Are you implementing in the scope of the PR?
| @Test | ||
| @Override | ||
| public void whenPostShellDescriptor_LocationIsReturned() throws ApiException, IOException { | ||
| // TODO: It uses normal GET unauthorized request, need to override and refactor |
There was a problem hiding this comment.
Are you implementing in the scope of the PR?
| @Test | ||
| @Override | ||
| public void whenPostSubmodelDescriptor_LocationIsReturned() throws ApiException, IOException { | ||
| // TODO: It uses normal GET unauthorized request, need to override and refactor |
There was a problem hiding this comment.
Are you implementing in the scope of the PR?
| <dependency> | ||
| <groupId>org.eclipse.digitaltwin.basyx</groupId> | ||
| <artifactId>basyx.submodelrepository-feature-authorization</artifactId> | ||
| <scope>test</scope> |
There was a problem hiding this comment.
using this pom as reference, but applies to all changed poms: did you run mvn dependency:analyze to see if all the added deps are used?
Signed-off-by: Mohammad Ghazanfar Ali Danish <ghazanfar.danish@iese.fraunhofer.de>
Signed-off-by: Mohammad Ghazanfar Ali Danish <ghazanfar.danish@iese.fraunhofer.de>
Signed-off-by: Mohammad Ghazanfar Ali Danish <ghazanfar.danish@iese.fraunhofer.de>
mateusmolina-iese
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of ConnectedAasManager should be extended to enable authorized requests.
This PR implements authorized versions of below Connected components:
Signed-off-by: Mohammad Ghazanfar Ali Danish ghazanfar.danish@iese.fraunhofer.de