make Operation a Namespace
#151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkhsjdhjs
force-pushed
the
feature/operation_namespace
branch
from
d4a2c6e
to
d0cf3d5
Compare
This commit makes `Operation` inherit from `UniqueIdShortNamespace`, to implement Constraint AASd-134: For an Operation, the idShort of all inputVariable/value, outputVariable/value, and inoutputVariable/value shall be unique. In the DotAAS spec, the attributes `inputVariable`, `outputVariable` and `inoutputVariable` of `Operation` are defined to be a collection of `OperationVariable` instances, which themselves just contain a single `SubmodelElement`. Thus, the `OperationVariable` isn't really required for `Operation`, as the `Operation` can just contain the `SubmodelElements` directly, without an unnecessary wrapper. This makes `Operation` less tedious to use and also allows us to use normal `NamespaceSets` for the 3 attributes, which together with the `UniqueIdShortNamespace` ensure, that the `idShort` of all contained `SubmodelElements` is unique across all 3 attributes. Aside this, the examples are updated since `SubmodelElements` as children of an `Operation` are now linked to the parent. This prevents us from reusing other `SubmodelElements` as `OperationVariables` as it was done previously, since each `SubmodelElement` can only have one parent. Fix eclipse-basyx#146 eclipse-basyx#148
jkhsjdhjs
force-pushed
the
feature/operation_namespace
branch
from
d0cf3d5
to
a21b5cb
Compare
jkhsjdhjs
changed the title
OperationVariable a NamespaceOperation a Namespace
|
Looks good to me |
This was referenced Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes
Operationinherit fromUniqueIdShortNamespace, to implement Constraint AASd-134:For an Operation, the idShort of all inputVariable/value, outputVariable/value, and inoutputVariable/value shall be unique.
In the DotAAS spec, the attributes
inputVariable,outputVariableandinoutputVariableofOperationare defined to be a collection ofOperationVariableinstances, which themselves just contain a singleSubmodelElement. Thus, theOperationVariableisn't really required forOperation, as theOperationcan just contain theSubmodelElementsdirectly, without an unnecessary wrapper. This makesOperationless tedious to use and also allows us to use normalNamespaceSetsfor the 3 attributes, which together with theUniqueIdShortNamespaceensure, that theidShortof all containedSubmodelElementsis unique across all 3 attributes.Aside this, the examples are updated since
SubmodelElementsas children of anOperationare now linked to the parent. This prevents us from reusing otherSubmodelElementsasOperationVariablesas it was done previously, since eachSubmodelElementcan only have one parent.Fix #146 #148