Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated update site links in features #1108

Closed
ajohnson1 opened this issue Nov 15, 2022 · 3 comments · Fixed by #1163
Closed

Outdated update site links in features #1108

ajohnson1 opened this issue Nov 15, 2022 · 3 comments · Fixed by #1163

Comments

@ajohnson1
Copy link

I noticed that the feature jar org.eclipse.birt.engine.runtime_4.10.0.v202210011458.jar had feature.xml with

   <url>
      <update label="%updateSiteName" url="http://download.eclipse.org/birt/update-site/4.9"/>
      <discovery label="%updateSiteName" url="http://download.eclipse.org/birt/update-site/4.9"/>
   </url>

so the wrong update site.

Running Search for update-site on GitHub birt shows quite a few other cases where the update site reference has not been changed for a new version of BIRT.

These should be updated for each release (not sure what to do while developing 4.11 as the 4.11 update site won't be live, but it probably doesn't matter as developers will know that and can fix it if needed.)

@wimjongman
Copy link
Contributor

Thanks for noticing. These all need to be replaced with: https://download.eclipse.org/birt/update-site/latest/

Can you make a PR?

@gab1one
Copy link
Contributor

gab1one commented Jan 2, 2023

Hi @wimjongman, I created a PR for this: #1163

@wimjongman
Copy link
Contributor

Thanks, Gabriel!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants