Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image handling with issues (special cases): 1) space at file-URL 2) grid cell with multiple images 3) svg encoded images #1416

Closed
speckyspooky opened this issue Sep 15, 2023 · 2 comments
Closed

Image handling with issues (special cases): 1) space at file-URL 2) grid cell with multiple images 3) svg encoded images #1416

speckyspooky opened this issue Sep 15, 2023 · 2 comments
Assignees
@speckyspooky
Labels
BugFix Change to correct issues
Milestone
4.14

Comments

@speckyspooky
Copy link
Contributor

Based of the changes of #1401 and the testing I figured out 3 other existing issues.

The 3 found topics (independent of this change):

  1. file-url with an blank character/space cause in some situations illegal character exception
  • fix: escape the blank-character before the url will be used like path
  1. excel-spudsoft emitter get a class cast exception if I have 2 html-tag-images in 1 cell
  • fix: at the according position check the class before the cast will be executed
  1. data-url of svg which is base64 encoded but internal not URL-encoded, this cause an illegal argument exception
@speckyspooky speckyspooky self-assigned this Sep 15, 2023
@speckyspooky
Copy link
Contributor Author

speckyspooky commented Sep 15, 2023 •
edited

I will create a PR for the 3 topics.

@speckyspooky speckyspooky mentioned this issue Sep 16, 2023
Merged
@speckyspooky speckyspooky added this to the 4.14 milestone Sep 16, 2023
@speckyspooky speckyspooky added the BugFix Change to correct issues label Sep 16, 2023
speckyspooky added a commit that referenced this issue Sep 19, 2023
@speckyspooky
Improved handling of space characters at file-url and svg-images base…
d72d5fb 
…64-encoded (#1416) (#1417)

* Improved handling of space characters in file-url and images with
base64-encoded images

* Workflow added line to "Clean up runner logs" based on sudo-command

* Changed workflow sequence first cancel previous run and afterwards clean
up

* Clear only cache folders

* Removed github action at ci.yml (will be added with own PR)
@speckyspooky
Copy link
Contributor Author

Fixes are merged to the master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@speckyspooky speckyspooky

Labels
BugFix Change to correct issues
Projects
None yet
Milestone
4.14
Development

No branches or pull requests
1 participant
@speckyspooky