Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XLSX: row-height and col-width based on "px" wount be display correctly #1496

Closed
speckyspooky opened this issue Nov 11, 2023 · 2 comments
Closed

XLSX: row-height and col-width based on "px" wount be display correctly #1496

speckyspooky opened this issue Nov 11, 2023 · 2 comments
Assignees
@speckyspooky
Labels
BugFix Change to correct issues
Milestone
4.14

Comments

@speckyspooky
Copy link
Contributor

The (spudsoft) excel emitter doesn't display the row-height and the column-width based on the unit "px" not correctly the sizing will be set with default values. In compare of it the handling with the unit "mm" works correctly.

The support of "px" like a common unit should be supported.

Excel-result "1 mm" vs. "4 px" // mm: row2 & col3 (ok) // px: row4 & col5 (sizing error)

xlsx-row-height col-width-based-on-pixel-error

Excel-result required "1 mm" vs. "4 px" // mm: row2 & col3 (ok) // px: row4 & col5 (ok)

xlsx-row-height col-width-based-on-pixel-ok
speckyspooky added a commit to speckyspooky/birt that referenced this issue Nov 11, 2023
@speckyspooky
Fix the row height and column width of unit "px" (eclipse-birt#1496)
893d824
@speckyspooky speckyspooky mentioned this issue Nov 11, 2023
Merged
@speckyspooky speckyspooky added this to the 4.14 milestone Nov 11, 2023
@speckyspooky speckyspooky added the BugFix Change to correct issues label Nov 11, 2023
@speckyspooky speckyspooky self-assigned this Nov 11, 2023
@speckyspooky
Copy link
Contributor Author

The fix is implemented on PR #1497

speckyspooky added a commit that referenced this issue Nov 12, 2023
@speckyspooky
Fix excel issue to set the row height and column width of unit "px" c…
c60f9ec 
…orrectly (#1496) (#1497)

* Fix the row height and column width of unit "px" (#1496)
@speckyspooky
Copy link
Contributor Author

Merged to the BIRT-master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@speckyspooky speckyspooky

Labels
BugFix Change to correct issues
Projects
None yet
Milestone
4.14
Development

No branches or pull requests
1 participant
@speckyspooky