New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BIRT 4.15: SVG images won't be displayed on HTML-preview which are embedded on TEXT-element (type HTML) #1604
Comments
Yes, of course with that extension it works. I have done a small change at 2 classes which checks "external" sources It seems to me that the behavior is changed due to the changed tidy-parser behavior and therefore we got some effects. I will take a look into the file extension way because there we would need a special role to get the extension from the URL. |
@merks Option 1) Restore the behavior like BIRT 4.14 with embedded SVG directly into the preview - 2 changes
Option 2) Change the behavior to get the correct file extension and use the file integration - 1 change
Attached the screen of the 2 changes on my notepad for compare. |
My sense is that inline, option 1, would be better and more like what's specified in the report source. |
PR #1605 created to fix the issue. |
The retest with the nightly build was successful and the images will be displayed according to BIRT4.14 |
On my regression tests I found an issue with SVG-images which are embedded directly into a TEXT-element with type HTML.
The images won't be displayed longer on the HTML-preview.
The issue is given with BIRT 4.15 "nightly build" (and further versions of 4.15 2024).
BIRT 4.14 is correct and also the first BIRT 4.15 of December 2023 are fine.
I don't know which change cause the behavior. The problem is that till BIRT 4.14 the embedded SVG-images was directly embedded into the HTML-editor and the preview works fine.
The current 4.15 versions externalize the svg as file and the sources will be displayed like broken image.
As cross check, the output of PDF & DOCX works correct.
BIRT 4.15 nightly build
BIRT 4.14
image_issue_img_src.zip
The text was updated successfully, but these errors were encountered: