BIRT-preview root-tag not correct initialized #1304 #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attributes will be displayed at the top of each report eclipse-birt#1304
|
The result after my fix. The sequence of the method-calls is mendatory.
The change of #1291 cased the issue - 2 points:
I have reset the situation to the original order and renamed the method "addCellDiagonalSpecial" to "addCellDiagonalSpecialJs" |
HTML-document (based on the golden test case)
|
@wimjongman : Please review the fixes for approval to merge. @merks : I fixed the HTMLReportEmitter & imrpoved your reordering in such way that your new test case can be passed. |
|
This looks correct to me so I use my new permissions to merge your changes. 😀 |
|
Thanks for your merge and welcome to our team 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BIRT-preview root-tag not correct initialized, part of the root attributes will be displayed at the top of each report #1304