Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with spudsoft auto filter to avoid cell range issue (#998) #1431

Merged
merged 1 commit into from Sep 27, 2023
Merged

Fix issue with spudsoft auto filter to avoid cell range issue (#998) #1431

merged 1 commit into from Sep 27, 2023

Conversation

speckyspooky
Copy link
Contributor

Fix issue with spudsoft auto filter to avoid cell range issue (#998)

@speckyspooky speckyspooky mentioned this pull request Sep 23, 2023
Closed
@speckyspooky speckyspooky added the BugFix Change to correct issues label Sep 23, 2023
@speckyspooky speckyspooky added this to the 4.14 milestone Sep 23, 2023
@speckyspooky speckyspooky self-assigned this Sep 23, 2023
@speckyspooky
Copy link
Contributor Author

The fix avoid the cell range error and set the auto-filter to the correct line.

Screen of fixed version based on the demo report (bug_report.rptdesign #998 )

2023-09-23 16_17_53-bug_report xlsx - Geschützte Ansicht - Excel

@speckyspooky
Copy link
Contributor Author

@wimjongman
Hello Wim, my plan would be to merge that PR for the upcoming release of BIRT 4.14.
It would be nice if you had time to review the change.

wimjongman
wimjongman approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@wimjongman wimjongman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Thomas.

@speckyspooky speckyspooky merged commit 48c3357 into eclipse-birt:master Sep 27, 2023
3 checks passed
@speckyspooky speckyspooky deleted the Fix_spudsoft_excel_auto_filter branch March 28, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wimjongman wimjongman wimjongman approved these changes

Assignees

@speckyspooky speckyspooky

Labels
BugFix Change to correct issues
Projects
None yet
Milestone
4.14
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@speckyspooky @wimjongman