Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial prototype for porting to Jetty 12 #1448

Closed
wants to merge 1 commit into from

Conversation

merks
Copy link
Contributor

@merks merks commented Oct 10, 2023

@merks merks marked this pull request as draft October 10, 2023 13:41
@merks
Copy link
Contributor Author

merks commented Oct 10, 2023

This is just to see how well the build works, and for sharing with @claesrosell

@merks
Copy link
Contributor Author

merks commented Oct 10, 2023

Apparently the build doesn’t test that the web app works.

@claesrosell
Copy link
Contributor

I configured my remote ref wrong so now we have a new branch called pr-1448 in the main repo. I will remove it shortly.
Does github provide any means to push to a PR or does I need to create a PR to your branch in your fork?

@merks
Copy link
Contributor Author

merks commented Oct 11, 2023

I’m sure there is a way. But I don’t know the way. Don’t worry about starting a new branch or new different PR. Do whatever is easiest.

@wimjongman
Copy link
Contributor

I configured my remote ref wrong so now we have a new branch called pr-1448 in the main repo. I will remove it shortly. Does github provide any means to push to a PR or does I need to create a PR to your branch in your fork?

@claesrosell You can create a pull request and then force push to your branch at any moment to have the PR updated

@wimjongman
Copy link
Contributor

@merks can this be closed?

@merks merks closed this Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants