Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes some UI strangeness in Birt Designer #1479

Merged
merged 1 commit into from Nov 3, 2023

Conversation

claesrosell
Copy link
Contributor

Long since, when I just wanted to do a small fix for #840 I ended up doing some substantial changes to some custom UI controls, since they typically didn't work well on Linux and probably not on any system where the font differs from Windows default, incl UI scaling.

This PR addresses them as well as some other resource leaks.

TextCombo layout used on "Script tab"
Before
image
After
image

Chart style selectors
Before
image
After
image

Font selector
Before
image
After
image

@merks
Copy link
Contributor

merks commented Nov 3, 2023

It definitely looks more usable! 👍

Copy link
Contributor

@speckyspooky speckyspooky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and good point to enhance the UI of our other platforms.

@claesrosell claesrosell merged commit 3f1bfd7 into eclipse-birt:master Nov 3, 2023
3 checks passed
@speckyspooky speckyspooky added this to the 4.14 milestone Nov 4, 2023
@speckyspooky speckyspooky added the BugFix Change to correct issues label Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BugFix Change to correct issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants