Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue with null-reference of uri in SvgFile.isSvg() (#1525) #1526

Conversation

speckyspooky
Copy link
Contributor

The method isSvg(String) needs additional brackets to avoid a possible NullPointerException.

@speckyspooky speckyspooky added this to the 4.15 milestone Dec 18, 2023
@speckyspooky speckyspooky added the BugFix Change to correct issues label Dec 18, 2023
@speckyspooky speckyspooky self-assigned this Dec 18, 2023
@wimjongman
Copy link
Contributor

The OP mentioned that this bug was located in two files.

@wimjongman wimjongman linked an issue Dec 18, 2023 that may be closed by this pull request
Copy link
Contributor

@wimjongman wimjongman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@wimjongman wimjongman merged commit 3fdaf38 into eclipse-birt:master Dec 18, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BugFix Change to correct issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPE in SvgFile.isSvg(String)
2 participants