Lock the target platform onto stable update sites

[merks]

Update the setup for generating this target platform, but also easily configured to switch back to on-going development versions.

Fix compile problems compiling against the latest GEF release.

#1572

[speckyspooky]

Hello Ed,
in your target-file I can see that we have know both javascript-libraries added.
If you want it in such combination to have both at same time?
Could it be that it as an effect on #1590... or it is independent (?)

[merks]

If I try to exclude it via a negative requirement:

The resolution fails:

ERROR: org.eclipse.equinox.p2.director code=1 Cannot complete the install because some dependencies are not satisfiable
  at org.eclipse.oomph.targlets.internal.core.TargletContainer.forceUpdate(TargletContainer.java:919)
  at org.eclipse.oomph.setup.targlets.impl.TargletTaskImpl$4.run(TargletTaskImpl.java:1232)
  at org.eclipse.oomph.util.pde.TargetPlatformUtil.runWithTargetPlatformService(TargetPlatformUtil.java:120)
  at org.eclipse.oomph.setup.targlets.impl.TargletTaskImpl.perform(TargletTaskImpl.java:1092)
  at org.eclipse.oomph.setup.internal.core.SetupTaskPerformer.doPerformNeededSetupTasks(SetupTaskPerformer.java:3864)
  at org.eclipse.oomph.setup.internal.core.SetupTaskPerformer$WorkspaceUtil$1.run(SetupTaskPerformer.java:5200)
  at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2448)
  at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2473)
  at org.eclipse.oomph.setup.internal.core.SetupTaskPerformer$WorkspaceUtil.performNeededSetupTasks(SetupTaskPerformer.java:5193)
  at org.eclipse.oomph.setup.internal.core.SetupTaskPerformer.performNeededSetupTasks(SetupTaskPerformer.java:3798)
  at org.eclipse.oomph.setup.internal.core.SetupTaskPerformer.performTriggeredSetupTasks(SetupTaskPerformer.java:3773)
  at org.eclipse.oomph.setup.internal.core.SetupTaskPerformer.perform(SetupTaskPerformer.java:3651)
  at org.eclipse.oomph.setup.ui.wizards.ProgressPage$9.run(ProgressPage.java:592)
  at org.eclipse.oomph.setup.ui.wizards.ProgressPage$11$1.run(ProgressPage.java:721)
  at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)
  ERROR: org.eclipse.equinox.p2.director code=0 Software being installed: artificial_root 1.0.0.v1710227605661
  ERROR: org.eclipse.equinox.p2.director code=1 Cannot satisfy dependency:
    ERROR: org.eclipse.equinox.p2.director code=0 From: artificial_root 1.0.0.v1710227605661
    ERROR: org.eclipse.equinox.p2.director code=0 To: org.eclipse.equinox.p2.iu; org.mozilla.javascript 0.0.0, min=0, max=0
  ERROR: org.eclipse.equinox.p2.director code=1 Cannot satisfy dependency:
    ERROR: org.eclipse.equinox.p2.director code=0 From: artificial_root 1.0.0.v1710227605661
    ERROR: org.eclipse.equinox.p2.director code=0 To: org.eclipse.equinox.p2.iu; org.eclipse.birt.core 0.0.0
  ERROR: org.eclipse.equinox.p2.director code=1 Cannot satisfy dependency:
    ERROR: org.eclipse.equinox.p2.director code=0 From: BIRT Core Package 4.12.0.v202211281949 (org.eclipse.birt.core 4.12.0.v202211281949)
    ERROR: org.eclipse.equinox.p2.director code=0 To: osgi.bundle; org.mozilla.javascript 1.7.4

So we'll need to eliminate that use of the bundle to eliminate the bundle from the target platform (and if the wtp dependencies don't require it).

Oh, strange, that is an older version of BIRT. Investigating.

[merks]

I see now! Targlet resolution was including binary equivalents, so for any project being imported, if there is a corresponding binary version available in one of the p2 repositories, that version is included in the target platform. But we really don't want that for BIRT especially because the release train repository includes really old versions of BIRT with old dependencies. So I turned that off and regenerated the target platform.

All that being said, I think this had zero impact on your problem and zero impact the build. The final build result only includes the new version of the bundle:

And the problem you show is the result of restrictive access rules on the debug package of the rhino bundle.

[speckyspooky]

Sounds good Ed, I will update my fork with that and go ahead with the test on my side.