Fix memory leak & and use Map instead of list to avoid itterating an Array constantly inside a synchronized block #1635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvbtup
approved these changes
Apr 18, 2024
merks
requested changes
Apr 18, 2024
data/org.eclipse.birt.data/src/org/eclipse/birt/data/engine/impl/CancelManager.java
Outdated
Show resolved
Hide resolved
|
It would be great if you could squash this into a single commit. I'm not sure how to actually do that with EGit though. But if you don't know how to do it either, I can try to help with that. Thanks for contributing! |
|
I have no idea how to actually do it ;) |
giangianoulas
force-pushed
the
MemoryLeak_&_Performance
branch
from
46b6a89
to
976efb5
Compare
|
FYI, I've been investigating why the build fails with memory exceptions. I finally got one to pass but now your force push kicked another build:
Let's see how that goes. |
|
Commits are now squashed |
merks
approved these changes
Apr 19, 2024
|
Thanks for contributing and for squashing too. 🏅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from List to Map on CancelManager to improve performance,
Fix memory leak & reduce scope of synchronized block Issue #1633