Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement to add ECMAScript 6 support (#1574) #1682

Merged
merged 2 commits into from
May 13, 2024
Merged

Enhancement to add ECMAScript 6 support (#1574) #1682

merged 2 commits into from
May 13, 2024

Conversation

speckyspooky
Copy link
Contributor

Enhancement to add ECMAScript 6 support (#1574)

@speckyspooky speckyspooky added the Enhancement Small change to improve the current supported functionality label May 12, 2024
@speckyspooky speckyspooky added this to the 4.16 milestone May 12, 2024
@speckyspooky speckyspooky self-assigned this May 12, 2024
@speckyspooky
Copy link
Contributor Author

Added option of ECMAScript 6 and configuration

JavascriptVersion.java
- content: initialization of the JavaScript engine
- change: new class to analysis the configured JVM parameter to get the JavaScript language version number
- default: ES6

JavascriptEngine.java
- content: initialization of the JavaScript engine
- change: set JavaScript language version on the JavaScript engine

ScriptValidator.java
- content: validator of the JavaScript scripts
- change: set JavaScript language version on the JavaScript engine

MANIFEST.MF of ScriptValidator
- change: import the class "JavascriptVersion.java"

New report version number

IDesignSchemaConstants.java
- content: define current report version nummer
- change: changed default report version number "3.2.25"

VersionUtil.java
- content: available report version numbers
- change: added new version number "3.2.25"

hvbtup
hvbtup reviewed May 13, 2024
View reviewed changes
...birt.report.engine.script.javascript/src/org/eclipse/birt/report/engine/javascript/README.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The markdown file contains HTML break elements. Why? I think it's better to just use an empty line to create paragraphs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed.

wimjongman
wimjongman approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@wimjongman wimjongman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woot! Thanks, Thomas!

@speckyspooky speckyspooky merged commit 1e09901 into eclipse-birt:master May 13, 2024
3 of 4 checks passed
@speckyspooky speckyspooky mentioned this pull request May 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvbtup hvbtup hvbtup left review comments

@wimjongman wimjongman wimjongman approved these changes

Assignees

@speckyspooky speckyspooky

Labels
Enhancement Small change to improve the current supported functionality
Projects
None yet
Milestone
4.16
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@speckyspooky @wimjongman @hvbtup