Improve image comparison in chart unit tests #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Number of tests in /testsuites/org.eclipse.birt.report.tests.chart and /chart/org.eclipse.birt.chart.tests packages may fail on Linux due to actual-to-golden image (JPG, PNG, SVG) comparison is done using byte comparison. The files may look similar visually, but different internally. This is solved as: * New image comparison utility was implemented to compare image files by comparing average weighted brightness in corresponding blocks. It can also compare images of different sizes. Settings are parameterized. The default settings were confirmed to work in most tests. If the images are found to be different, a difference image is returned with blocks failed validation marked in red. * Updated failed regression and unit test cases to use the new image comparison where appropriate. * File comparison utility was updated to (optionally) ignore line breaks for comparing text files created on different platforms. Signed-off-by: Serguei Krivtsov <skrivtsov@actuate.com>
Signed-off-by: Serguei Krivtsov <skrivtsov@actuate.com>
bkiselka
pushed a commit
to bkiselka/birt
that referenced
this pull request
Jun 12, 2019
Fix Javadoc warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Number of tests in /testsuites/org.eclipse.birt.report.tests.chart and /chart/org.eclipse.birt.chart.tests packages may fail on Linux due to actual-to-golden image (JPG, PNG, SVG) comparison is done using byte comparison. The files may look similar visually, but different internally. This is solved as:
Signed-off-by: Serguei Krivtsov skrivtsov@actuate.com