Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postscript on linux is not able to find bold nbsp font. #346

Merged
merged 2 commits into from Oct 4, 2016
Merged

Postscript on linux is not able to find bold nbsp font. #346

merged 2 commits into from Oct 4, 2016

Conversation

sguan-actuate
Copy link
Contributor

Added the condition to take care of this specific case.

Signed-off-by: sguan sguan@actuate.com

Added the condition to take care of this specific case.


Signed-off-by: sguan <sguan@actuate.com>
@@ -1214,6 +1216,10 @@ private String toPSString( String data )
public int getGlyphIndex( char c )
{
int[] glyphIndexs = (int[]) getCMap( ).get( (int) c );
if( glyphIndexs == null && c == NBSP )

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if c!=NBSP NPE may be thrown

Copy link

@yulinwang yulinwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if c!=NBSP NPE may be thrown

Changes after review to cover all NPE cases.  This will return space
character for all


Signed-off-by: sguan <sguan@actuate.com>
@yulinwang yulinwang merged commit 993423e into eclipse-birt:master Oct 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants