Changes made for masterpage in properties corrupted in layout page #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Element MasterPage has its own height and width property, which have triggers to trigger validators. However, it also has height and width from style. In this case, during ElementDefn.buildCachedPropertyDefns( ), height and width from style will over write the original property, and hence lose those triggers.Might need a way to merge them instead of over write. 2. define allowed units for simpleMasterPage footer and header Signed-off-by: Shijie Zhang <szhang@opentext.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
width from style will over write the original property, and hence lose
those original properties.
Signed-off-by: Shijie Zhang szhang@opentext.com