Fix chart core tests #685 #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Added some java documentation
Added fragment to provide dependency [1] Fixed some Locale dependent tests [1] The chart core tests were failing due to an incompatible java/osgi construct in org.apache.batik.transcoder. The transcoder "bundle" is doing a Class.forname(String) on a class that is not listed as a dependency. This happens in class org.apache.batik.transcoder.image.PNGTranscoder#getWriteAdapter which is looking for "org.apache.batik.ext.awt.image.codec.png.PNGTranscoderInternalCodecWriteAdapter" To fool this "bundle", a fragment bundle is introduced with o.a.b.transcoder as the master plugin that depends on the "org.apache.batik.codec" bundle and in this way provides the dependency.
Added fragment to provide dependency [1] Fixed some Locale dependent tests [1] The chart core tests were failing due to an incompatible java/osgi construct in org.apache.batik.transcoder. The transcoder "bundle" is doing a Class.forname(String) on a class that is not listed as a dependency. This happens in class org.apache.batik.transcoder.image.PNGTranscoder#getWriteAdapter which is looking for "org.apache.batik.ext.awt.image.codec.png.PNGTranscoderInternalCodecWriteAdapter" To fool this "bundle", a fragment bundle is introduced with o.a.b.transcoder as the master plugin that depends on the "org.apache.batik.codec" bundle and in this way provides the dependency.
Added fragment to provide dependency [1] Fixed some Locale dependent tests [1] The chart core tests were failing due to an incompatible java/osgi construct in org.apache.batik.transcoder. The transcoder "bundle" is doing a Class.forname(String) on a class that is not listed as a dependency. This happens in class org.apache.batik.transcoder.image.PNGTranscoder#getWriteAdapter which is looking for "org.apache.batik.ext.awt.image.codec.png.PNGTranscoderInternalCodecWriteAdapter" To fool this "bundle", a fragment bundle is introduced with o.a.b.transcoder as the master plugin that depends on the "org.apache.batik.codec" bundle and in this way provides the dependency. Also added batik.w3c.dom as pkg dependency to the same
Added fragment to provide dependency [1] Fixed some Locale dependent tests [1] The chart core tests were failing due to an incompatible java/osgi construct in org.apache.batik.transcoder. The transcoder "bundle" is doing a Class.forname(String) on a class that is not listed as a dependency. This happens in class org.apache.batik.transcoder.image.PNGTranscoder#getWriteAdapter which is looking for "org.apache.batik.ext.awt.image.codec.png.PNGTranscoderInternalCodecWriteAdapter" To fool this "bundle", a fragment bundle is introduced with o.a.b.transcoder as the master plugin that depends on the "org.apache.batik.codec" bundle and in this way provides the dependency. An identical trick was pulled adding batik.w3c.dom as pkg dependency to org.apache.batik.dom
wimjongman
force-pushed
the
Fix_chart_core_tests_#685
branch
from
0c0f91a
to
b9e6ada
Compare
Added o.a.batik.dom.birt.ext to birt feature This is a fragment extending batik.dom so that it can see org.apache.batik.w3c.dom It solves the following dependency issue: java.lang.NoClassDefFoundError: org/apache/batik/w3c/dom/ElementTraversal at org.eclipse.birt.chart.tests.device.render.ImageOutputBaseTest.runTest(ImageOutputBaseTest.java:100) Caused by: java.lang.ClassNotFoundException: org.apache.batik.w3c.dom.ElementTraversal cannot be found by org.apache.batik.dom_1.14.0.v20210324-0332 at org.eclipse.birt.chart.tests.device.render.ImageOutputBaseTest.runTest(ImageOutputBaseTest.java:100)
Added o.a.batik.dom.birt.ext to birt feature Added batik.ext 1.14 to target This is a fragment extending batik.dom so that it can see org.apache.batik.w3c.dom It solves the following dependency issue: java.lang.NoClassDefFoundError: org/apache/batik/w3c/dom/ElementTraversal at org.eclipse.birt.chart.tests.device.render.ImageOutputBaseTest.runTest(ImageOutputBaseTest.java:100) Caused by: java.lang.ClassNotFoundException: org.apache.batik.w3c.dom.ElementTraversal cannot be found by org.apache.batik.dom_1.14.0.v20210324-0332 at org.eclipse.birt.chart.tests.device.render.ImageOutputBaseTest.runTest(ImageOutputBaseTest.java:100)
Added o.a.batik.dom.birt.ext to birt feature Added batik.ext 1.14 to target This is a fragment extending batik.dom so that it can see org.apache.batik.w3c.dom It solves the following dependency issue: java.lang.NoClassDefFoundError: org/apache/batik/w3c/dom/ElementTraversal at org.eclipse.birt.chart.tests.device.render.ImageOutputBaseTest.runTest(ImageOutputBaseTest.java:100) Caused by: java.lang.ClassNotFoundException: org.apache.batik.w3c.dom.ElementTraversal cannot be found by org.apache.batik.dom_1.14.0.v20210324-0332 at org.eclipse.birt.chart.tests.device.render.ImageOutputBaseTest.runTest(ImageOutputBaseTest.java:100)
Added o.a.batik.dom.birt.ext to birt feature Added batik.ext 1.14 to target This is a fragment extending batik.dom so that it can see org.apache.batik.w3c.dom It solves the following dependency issue: java.lang.NoClassDefFoundError: org/apache/batik/w3c/dom/ElementTraversal at org.eclipse.birt.chart.tests.device.render.ImageOutputBaseTest.runTest(ImageOutputBaseTest.java:100) Caused by: java.lang.ClassNotFoundException: org.apache.batik.w3c.dom.ElementTraversal cannot be found by org.apache.batik.dom_1.14.0.v20210324-0332 at org.eclipse.birt.chart.tests.device.render.ImageOutputBaseTest.runTest(ImageOutputBaseTest.java:100)
Added o.a.batik.dom.birt.ext to birt feature Added batik.ext 1.14 to target This is a fragment extending batik.dom so that it can see org.apache.batik.w3c.dom It solves the following dependency issue: java.lang.NoClassDefFoundError: org/apache/batik/w3c/dom/ElementTraversal at org.eclipse.birt.chart.tests.device.render.ImageOutputBaseTest.runTest(ImageOutputBaseTest.java:100) Caused by: java.lang.ClassNotFoundException: org.apache.batik.w3c.dom.ElementTraversal cannot be found by org.apache.batik.dom_1.14.0.v20210324-0332 at org.eclipse.birt.chart.tests.device.render.ImageOutputBaseTest.runTest(ImageOutputBaseTest.java:100)
Added o.a.batik.dom.birt.ext to birt feature Added batik.ext 1.14 to target Disable the test so that it can at least run locally. This is a fragment extending batik.dom so that it can see org.apache.batik.w3c.dom It solves the following dependency issue: java.lang.NoClassDefFoundError: org/apache/batik/w3c/dom/ElementTraversal at org.eclipse.birt.chart.tests.device.render.ImageOutputBaseTest.runTest(ImageOutputBaseTest.java:100) Caused by: java.lang.ClassNotFoundException: org.apache.batik.w3c.dom.ElementTraversal cannot be found by org.apache.batik.dom_1.14.0.v20210324-0332 at org.eclipse.birt.chart.tests.device.render.ImageOutputBaseTest.runTest(ImageOutputBaseTest.java:100)
Added o.a.batik.dom.birt.ext to birt feature Added batik.ext 1.14 to target Disable the test so that it can at least run locally. This is a fragment extending batik.dom so that it can see org.apache.batik.w3c.dom It solves the following dependency issue: java.lang.NoClassDefFoundError: org/apache/batik/w3c/dom/ElementTraversal at org.eclipse.birt.chart.tests.device.render.ImageOutputBaseTest.runTest(ImageOutputBaseTest.java:100) Caused by: java.lang.ClassNotFoundException: org.apache.batik.w3c.dom.ElementTraversal cannot be found by org.apache.batik.dom_1.14.0.v20210324-0332 at org.eclipse.birt.chart.tests.device.render.ImageOutputBaseTest.runTest(ImageOutputBaseTest.java:100)
|
Alexander, I can't get it to work in the CI build. However, with this patch, we can at least run the test locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added fragment to provide dependency [1]
Fixed some Locale dependent tests
[1]
The chart core tests were failing due to an incompatible
java/osgi construct in org.apache.batik.transcoder.
The transcoder "bundle" is doing a Class.forname(String)
on a class that is not listed as a dependency.
This happens in class
org.apache.batik.transcoder.image.PNGTranscoder#getWriteAdapter
which is looking for
"org.apache.batik.ext.awt.image.codec.png.PNGTranscoderInternalCodecWriteAdapter"
To fool this "bundle", a fragment bundle is introduced with
o.a.b.transcoder as the master plugin that depends on the
"org.apache.batik.codec" bundle and in this way provides the dependency.