Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSEditor is leaking fonts #734 #748

Merged
merged 1 commit into from
Nov 27, 2021
Merged

JSEditor is leaking fonts #734 #748

merged 1 commit into from
Nov 27, 2021

Conversation

claesrosell
Copy link
Contributor

No longer generating fonts for this label, but using the FontRegistry to use JFace default fonts instead.

@claesrosell
JSEditor is leaking fonts eclipse-birt#734
29137df 
No longer generating fonts for this label, but using the FontRegistry to
access JFace default fonts.
@wimjongman wimjongman added this to the 4.9 milestone Nov 25, 2021
@wimjongman wimjongman linked an issue Nov 25, 2021 that may be closed by this pull request
org.eclipse.birt.report.designer.internal.ui.editors.script.JSEditor is leaking Fonts #734
Closed
ruspl-afed
ruspl-afed reviewed Nov 27, 2021
View reviewed changes
Copy link
Contributor

@ruspl-afed ruspl-afed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not to keep the existing font styles during the fix? We can use registry to keep our own font for reuse.

@ruspl-afed
Copy link
Contributor

Why not to keep the existing font styles during the fix? We can use registry to keep our own font for reuse.

Please ignore this comment

ruspl-afed
ruspl-afed approved these changes Nov 27, 2021
View reviewed changes
Copy link
Contributor

@ruspl-afed ruspl-afed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruspl-afed ruspl-afed merged commit 2a94776 into eclipse-birt:master Nov 27, 2021
@claesrosell claesrosell deleted the JSEditor_is_leaking_Fonts_#734 branch November 27, 2021 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruspl-afed ruspl-afed ruspl-afed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.9
Development

Successfully merging this pull request may close these issues.

org.eclipse.birt.report.designer.internal.ui.editors.script.JSEditor is leaking Fonts
3 participants
@claesrosell @ruspl-afed @wimjongman