Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preSharedKeyIdentity to the ServerHandshaker. #749

Merged
merged 1 commit into from
Sep 13, 2018

Conversation

boaks
Copy link
Contributor

@boaks boaks commented Sep 12, 2018

Support creating statistics.

Signed-off-by: Achim Kraus achim.kraus@bosch-si.com

Support creating statistics.

Signed-off-by: Achim Kraus <achim.kraus@bosch-si.com>
@boaks
Copy link
Contributor Author

boaks commented Sep 12, 2018

Second part of the fix for #744

@boaks boaks added this to the 2.0.0-M12 milestone Sep 13, 2018
@boaks
Copy link
Contributor Author

boaks commented Sep 13, 2018

Alternatively, the already available clientKeyExchange could be exposed public.
Then check for specific subclass PSKClientKeyExchange and read the identifier there.

@sbernard31
If you can give us your feedback of your preferred variant,
FMPOV, we could finalize the work for the 2.0.0-M12 and release that next week.

@sbernard31
Copy link
Contributor

I have no strong opinion about that.
Maybe the clientKeyExchange way is more flexible has we can access to more data than just the PSKIdentity ? But this is not a strong argument so I'm ok with the current implementation too.

@boaks
Copy link
Contributor Author

boaks commented Sep 13, 2018

So, go for this.

@boaks boaks merged commit dd008fd into eclipse-californium:2.0.x Sep 13, 2018
@boaks boaks deleted the fix_744_2 branch April 5, 2019 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants