[fix #75] Server Treats NON-Message as CON-Message #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Request#type is now Type.CON by default. CoapClient: Move setting the request type to the convenience methods. Client code can use the advanced() methods for sending a request that it has configured manually whereas the convenience methods can be used in the established way. Uses Request#uri (if not blank) in the advanced() methods instead of CoapClient#uri. Signed-off-by: Eugene Nikolaev <eug.nikolaev@gmail.com>
|
|
||
| CoapResponse resp = client.advanced(request); | ||
|
|
||
| Assert.assertEquals(CONTENT_1, resp.getResponseText()); |
There was a problem hiding this comment.
How does this assert that the request indeed contained a CON? The fact that we receive a response merely means that the request has been received and processed by the server ... We should at least assert that the response is of type ACK, i.e. the server piggybacked the response, shouldn't we?
There was a problem hiding this comment.
Yes, thanks, sure we should...
I'll add the asserts but here is another one issue, I'll point to it. Need advice, please.
|
Closed due to new pull-request creation (apply review comments) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request#type is now Type.CON by default.
CoapClient: Move setting the request type to the convenience methods.
Client code can use the advanced() methods for sending a request that
it has configured manually whereas the convenience methods can be used
in the established way.
Uses Request#uri (if not blank) in the advanced() methods instead of CoapClient#uri.
Signed-off-by: Eugene Nikolaev eug.nikolaev@gmail.com