Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Welcome view with a SWT Implementation #2662

Closed
etraisnel2 opened this issue Jun 21, 2023 · 2 comments
Closed

Replace Welcome view with a SWT Implementation #2662

etraisnel2 opened this issue Jun 21, 2023 · 2 comments
Milestone
7.0

Comments

@etraisnel2
Copy link
Contributor

In 7.0
Edge Browser doesn't display the Welcome Page properly (local html being seen as a security issue by edge)
To fix that, we need a SWT Implementation of the Welcome View, so that links are displayed the same way they used to be
etraisnel2 added a commit to etraisnel2/capella that referenced this issue Jun 21, 2023
@etraisnel2
eclipse-capella#2662 SWT Implementation of Welcome Page
07711fc 
Welcome page html implementation is replaced by a SWT version.
an additional extension point was created to be able to contribute to
this page

Change-Id: Id9387b0e6e3a9ead6a607e8b1cae9661c7dd00cc
Signed-off-by: Erwann Traisnel <erwann.traisnel@obeo.fr>
etraisnel2 added a commit to etraisnel2/capella that referenced this issue Jun 27, 2023
@etraisnel2
eclipse-capella#2662 SWT Implementation of Welcome Page
0c08be2 
Welcome page html implementation is replaced by a SWT version.
an additional extension point was created to be able to contribute to
this page

Change-Id: Id9387b0e6e3a9ead6a607e8b1cae9661c7dd00cc
Signed-off-by: Erwann Traisnel <erwann.traisnel@obeo.fr>
etraisnel2 added a commit to etraisnel2/capella that referenced this issue Jun 27, 2023
@etraisnel2
eclipse-capella#2662 SWT Implementation of Welcome Page
8bd8fa5 
Welcome page html implementation is replaced by a SWT version.
an additional extension point was created to be able to contribute to
this page

Change-Id: Id9387b0e6e3a9ead6a607e8b1cae9661c7dd00cc
Signed-off-by: Erwann Traisnel <erwann.traisnel@obeo.fr>
etraisnel2 added a commit to etraisnel2/capella that referenced this issue Jun 27, 2023
@etraisnel2
eclipse-capella#2662 SWT Implementation of Welcome Page
ca1dac4 
Welcome page html implementation is replaced by a SWT version.
an additional extension point was created to be able to contribute to
this page

Change-Id: Id9387b0e6e3a9ead6a607e8b1cae9661c7dd00cc
Signed-off-by: Erwann Traisnel <erwann.traisnel@obeo.fr>
@pdulth pdulth added this to the 7.0 milestone Jul 3, 2023
etraisnel2 added a commit to etraisnel2/capella that referenced this issue Jul 3, 2023
@etraisnel2
eclipse-capella#2662 SWT Implementation of Welcome Page
e7b6168 
Welcome page html implementation is replaced by a SWT version.
an additional extension point was created to be able to contribute to
this page

Change-Id: Id9387b0e6e3a9ead6a607e8b1cae9661c7dd00cc
Signed-off-by: Erwann Traisnel <erwann.traisnel@obeo.fr>
etraisnel2 added a commit to etraisnel2/capella that referenced this issue Jul 5, 2023
@etraisnel2
eclipse-capella#2662 SWT Implementation of Welcome Page
99774a6 
Welcome page html implementation is replaced by a SWT version.
an additional extension point was created to be able to contribute to
this page

Internal contributions (from org.polarsys.capella.core.ui.intro) are displayed at the top
whereas external contributions are displayed at the bottom

Change-Id: Id9387b0e6e3a9ead6a607e8b1cae9661c7dd00cc
Signed-off-by: Erwann Traisnel <erwann.traisnel@obeo.fr>
pdulth pushed a commit that referenced this issue Jul 5, 2023
@etraisnel2 @pdulth
#2662 SWT Implementation of Welcome Page
53df910 
Welcome page html implementation is replaced by a SWT version.
an additional extension point was created to be able to contribute to
this page

Internal contributions (from org.polarsys.capella.core.ui.intro) are displayed at the top
whereas external contributions are displayed at the bottom

Change-Id: Id9387b0e6e3a9ead6a607e8b1cae9661c7dd00cc
Signed-off-by: Erwann Traisnel <erwann.traisnel@obeo.fr>
@etraisnel2
Copy link
Contributor Author

Small issue spotted when running the product

WelcomeView cannot be casted to CustomizableIntroPart

etraisnel2 added a commit to etraisnel2/capella that referenced this issue Dec 20, 2023
@etraisnel2
eclipse-capella#2662 Avoid ClassCastException on WelcomeView
d35b979 
Change-Id: Ie228d2257fe5f8ea5c5eabf22af9b96401b6545a
Signed-off-by: Erwann Traisnel <erwann.traisnel@obeo.fr>
@etraisnel2
Copy link
Contributor Author

There still seems to be an issue with dispose
image

pdulth pushed a commit to etraisnel2/capella that referenced this issue Jan 24, 2024
@etraisnel2 @pdulth
eclipse-capella#2662 Avoid ClassCastException on WelcomeView
ca4cdff 
Change-Id: Ie228d2257fe5f8ea5c5eabf22af9b96401b6545a
Signed-off-by: Erwann Traisnel <erwann.traisnel@obeo.fr>
pdulth pushed a commit that referenced this issue Jan 24, 2024
@etraisnel2 @pdulth
#2662 Avoid ClassCastException on WelcomeView
d9f48a2 
Change-Id: Ie228d2257fe5f8ea5c5eabf22af9b96401b6545a
Signed-off-by: Erwann Traisnel <erwann.traisnel@obeo.fr>
@pdulth pdulth closed this as completed Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0
Development

No branches or pull requests
2 participants
@pdulth @etraisnel2