#2061 Correcting the behavior of DiagramServices

[ebausson-obeo]

When DiagramServices tests an EdgeMapping for selection or visibility, the disconnect between EdgeMappingImpl and EdgeMappingWrapper is now managed, allowing easier integration of external features and plugins into Capella.

[eclipse-capella-bot]

🚀 Build master-PR-2713-1 started!

[eclipse-capella-bot]

🚀 Build master-PR-2713-2 started!

[eclipse-capella-bot]

😞 Build master-PR-2713-2 failed!

[ebausson-obeo]

Bonjour @pdulth, the CI has the same error on my three merge requests on this repository, on a plugin I haven't touched yet (I'm waiting to resolve pending issue before pushing the associated doc update).
Do you have any insight in what is going on? @lredor pointed me toward you in this specific case.
Thanks.

[INFO] Calling: /bin/sh -c cd '/home/jenkins/agent/workspace/capella-product_PR-2713/doc/plugins/org.polarsys.capella.developer.doc/html/api-docs/javadoc' && '/opt/tools/java/openjdk/jdk-17/latest/bin/javadoc' '@/home/jenkins/agent/workspace/capella-product_PR-2713/doc/plugins/org.polarsys.capella.developer.doc/target/javadoc.options.txt'
Loading source files for package null...
error: No source files for package null
1 error
[INFO] execution failed with rc = 2
org.polarsys.capella.developer.doc ................. FAILURE

[pdulth]

Bonjour @pdulth, the CI has the same error on my three merge requests on this repository, on a plugin I haven't touched yet (I'm waiting to resolve pending issue before pushing the associated doc update). Do you have any insight in what is going on? @lredor pointed me toward you in this specific case. Thanks.

[INFO] Calling: /bin/sh -c cd '/home/jenkins/agent/workspace/capella-product_PR-2713/doc/plugins/org.polarsys.capella.developer.doc/html/api-docs/javadoc' && '/opt/tools/java/openjdk/jdk-17/latest/bin/javadoc' '@/home/jenkins/agent/workspace/capella-product_PR-2713/doc/plugins/org.polarsys.capella.developer.doc/target/javadoc.options.txt'
Loading source files for package null...
error: No source files for package null
1 error
[INFO] execution failed with rc = 2
org.polarsys.capella.developer.doc ................. FAILURE

yep weird, i will look

[eclipse-capella-bot]

🚀 Build master-PR-2713-3 started!

[eclipse-capella-bot]

👍 Build master-PR-2713-3 is successfull! The product is available here.

[eclipse-capella-bot]

🚀 Build master-PR-2713-4 started!

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[eclipse-capella-bot]

👍 Build master-PR-2713-4 is successfull! The product is available here.

[pdulth]

FYI build is ok if you rebase your branch from master

[eclipse-capella-bot]

🚀 Build master-PR-2713-5 started!

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[eclipse-capella-bot]

👍 Build master-PR-2713-5 is successfull! The product is available here.

[lfasani]

According to @pdulth you should use DiagramService.isMapping directly instead of having your own code.
Philippe will test and may add additional comments

[ebausson-obeo]

According to @pdulth you should use DiagramService.isMapping directly instead of having your own code.
Philippe will test and may add additional comments

The change to DiagramService.isMapping was already committed 3 weeks ago is this branch. (commit: 447c86a )

[eclipse-capella-bot]

🚀 Build master-PR-2713-6 started!

[sonarcloud]

Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

[eclipse-capella-bot]

😟 Build master-PR-2713-6 is unstable! The product is available here.

[pdulth]

I tried using only DiagramServices.getDiagramServices().isMapping and the original issue with DiagramStyler/ExchangeCategory seems fixed.
Can you try #2810.
Thanks

[SteveMonnier]

Hi @pdulth, thanks for the new PR, I will check the scenario with your new PR and get back to you.