Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2860 Avoid NPEs when repair or migration are launched with modified diagrams and opened ActivityExplorer #2859

Closed
wants to merge 5 commits into from

Conversation

mPorhel
Copy link
Contributor

@mPorhel mPorhel commented Apr 23, 2024

No description provided.

@mPorhel mPorhel changed the title [Fix] Avoid NPE when session has been closed and has not been restored [fix] Avoid NPEs when repair or migration are launched with modified diagrams and opened ActivityExplorer Apr 24, 2024
…ot been restored

Signed-off-by: Maxime Porhel <maxime.porhel@obeo.fr>
Signed-off-by: Maxime Porhel <maxime.porhel@obeo.fr>
- Do not fire events if the saveable session is null or already closed
- Catch NPE due to saveable provider reinitalization between runnables
creation and their async execution.

Signed-off-by: Maxime Porhel <maxime.porhel@obeo.fr>
@mPorhel mPorhel changed the title [fix] Avoid NPEs when repair or migration are launched with modified diagrams and opened ActivityExplorer #2860 Avoid NPEs when repair or migration are launched with modified diagrams and opened ActivityExplorer Apr 24, 2024
…tion cancelled

Change-Id: I8154bed5896419bcc1055b954941a9c710aca437
Signed-off-by: Maxime Porhel <maxime.porhel@obeo.fr>
Change-Id: I4125dc020cc8f78b41dbdf7d11e7d5490b7bfa56
Signed-off-by: Maxime Porhel <maxime.porhel@obeo.fr>
Copy link

sonarcloud bot commented Apr 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@lfasani
Copy link
Contributor

lfasani commented May 15, 2024

You can close this PR because the commits are included in #2867

@pdulth pdulth closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants