Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix site creation for maven plugins #323

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Fix site creation for maven plugins #323

merged 1 commit into from
Aug 16, 2023

Conversation

fredg02
Copy link
Contributor

@fredg02 fredg02 commented Aug 9, 2023

  • change parent pom of Maven plugins to maven-plugin-parent
  • change parent pom of maven-plugin-parent to cbi-build-parent
  • fix URL to Eclipse Foundation logo in site.xml
  • the site can be generated by doing the following:
    1. Run mvn clean install -DskipTests in root dir
    2. Run mvn clean verify site -DskipTests in maven-plugins dir
    3. Run mvn site:stage in maven-plugins dir
    4. Site can be found at maven-plugins/target/staging/cbi-build-parent/maven-plugin-parent/index.html

@fredg02
Fix site creation for maven plugins
9c94a29 
- change parent pom of Maven plugins to maven-plugin-parent
- change parent pom of maven-plugin-parent to cbi-build-parent
- fix URL to Eclipse Foundation logo in site.xml
- the site can be generated by doing the following:
  1. Run `mvn clean install -DskipTests` in root dir
  2. Run `mvn clean verify site -DskipTests` in maven-plugins dir
  3. Run `mvn site:stage` in maven-plugins dir
  4. Site can be found at
maven-plugins/target/staging/cbi-build-parent/maven-plugin-parent/index.html
@fredg02 fredg02 requested a review from mbarbero August 9, 2023 12:43
@github-actions github-actions bot added the bug Something isn't working label Aug 9, 2023
@fredg02 fredg02 added documentation Improvements or additions to documentation enhancement New feature or request and removed bug Something isn't working labels Aug 9, 2023
mbarbero
mbarbero requested changes Aug 9, 2023
View reviewed changes
Copy link
Member

@mbarbero mbarbero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by doing that, you won't benefit from the setup in cbi-build-parent

@fredg02
Copy link
Contributor Author

fredg02 commented Aug 9, 2023

by doing that, you won't benefit from the setup in cbi-build-parent

Why not?
E.g. for eclipse-winsigner-plugin the parent pom hierarchy is changing from
eclipse-winsigner-plugin -> cbi-build-parent to
eclipse-winsigner-plugin -> maven-plugin-parent -> cbi-build-parent
so it should still inherit everything from the cbi-build-parent parent pom.

@mbarbero
Copy link
Member

uhm, I've mixed feeling about mixing up the hierarchy, but if it does not break anything, go for it (multimodules site generation is a mess)

@fredg02
Copy link
Contributor Author

fredg02 commented Aug 16, 2023 •
edited

I've compared the console log output of mvn clean verify -DskipTests for the main and fix_site_creation branches and found no noticeable differences.
If something breaks, I will roll back the commit.

@fredg02 fredg02 merged commit 446af85 into main Aug 16, 2023
7 checks passed
@fredg02 fredg02 deleted the fix_site_creation branch August 16, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbarbero mbarbero mbarbero requested changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fredg02 @mbarbero