Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse element transaction in ObjectDeleteHandler, if possible #11

Closed
estepper opened this issue Aug 28, 2023 · 0 comments
Closed

Reuse element transaction in ObjectDeleteHandler, if possible #11

estepper opened this issue Aug 28, 2023 · 0 comments
Assignees
@estepper
Labels
cdo-ui CDO Model Repository (User Interface) enhancement New feature or request
Milestone
4.24

Comments

@estepper
Copy link
Contributor

ObjectDeleteHandler (more concretely AbstractObjectHandler) was designed to work with CDOCheckouts, where the view is always a read-only CDOView. Hence it opens a new transaction upon the checkout view's session.

It turns out that this handler is also used in the CDOEditor, which may already have an open transaction. This transaction should be used for the objects to be deleted, so that NEW objects can also be deleted without ObjectNotFoundxceptions.
@estepper estepper added enhancement New feature or request cdo-ui CDO Model Repository (User Interface) labels Aug 28, 2023
@estepper estepper added this to the 4.24 milestone Aug 28, 2023
@estepper estepper self-assigned this Aug 28, 2023
estepper added a commit that referenced this issue Aug 28, 2023
@estepper
Reuse element transaction in ObjectDeleteHandler, if possible #11
1300b66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@estepper estepper

Labels
cdo-ui CDO Model Repository (User Interface) enhancement New feature or request
Projects
None yet
Milestone
4.24
Development

No branches or pull requests
1 participant
@estepper