Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closing a CDOView can open a new view for clearing the adapters #28

Closed
estepper opened this issue Oct 16, 2023 · 1 comment
Closed

Closing a CDOView can open a new view for clearing the adapters #28

estepper opened this issue Oct 16, 2023 · 1 comment
Assignees
@estepper
Labels
bug Something isn't working cdo-core CDO Model Repository (Core)
Milestone
4.25

Comments

@estepper
Copy link
Contributor

CDOViewImpl.doBeforeDeactivate() first detaches the view from the resource set and then calls clearAdapters(). If one of the adapters to be removed accesses the model, a new view is opened by the resource set, and left open forever.
@estepper estepper added bug Something isn't working cdo-core CDO Model Repository (Core) labels Oct 16, 2023
@estepper estepper added this to the 4.25 milestone Oct 16, 2023
@estepper estepper self-assigned this Oct 16, 2023
estepper added a commit that referenced this issue Oct 16, 2023
@estepper
Closing a CDOView can open a new view for clearing the adapters #28
cd23758
estepper added a commit that referenced this issue Oct 16, 2023
@estepper
Closing a CDOView can open a new view for clearing the adapters #28
4a5679d
@estepper
Copy link
Contributor Author

I also fixed the potential for a ConcurrentModificationException in CDOViewImpl.clearAdapters() by changing getModifiableObjects().values() to getObjectsList().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@estepper estepper

Labels
bug Something isn't working cdo-core CDO Model Repository (Core)
Projects
None yet
Milestone
4.25
Development

No branches or pull requests
1 participant
@estepper