-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge CDT Cloud update to 1.45.1 #84
Merge CDT Cloud update to 1.45.1 #84
Conversation
* Upgrade dependencies * Update jenkins job for windows to ensure that we download the correct version of node-gyp Contributed on behalf of STMicroelectronics
This may help to catch future errors
* update dependencies and versions * update builtins Contributed on behalf of STMicroelectronics
Contributed on behalf of STMicroelectronics Signed-off-by: Johannes Faltermeier <jfaltermeier@eclipsesource.com>
Contributed on behalf of STMicroelectronics Signed-off-by: Johannes Faltermeier <jfaltermeier@eclipsesource.com>
* add required plugins that are missing from the vscode-builtin-extensions-pack Contributed on behalf of STMicroelectronics Signed-off-by: Johannes Faltermeier <jfaltermeier@eclipsesource.com>
* rename nsis installer artifact to TheiaIDESetup.exe Contributed on behalf of STMicroelectronics Signed-off-by: Johannes Faltermeier <jfaltermeier@eclipsesource.com>
Contributed on behalf of STMicroelectronics Signed-off-by: Johannes Faltermeier <jfaltermeier@eclipsesource.com>
Contributed on behalf of STMicroelectronics Signed-off-by: Johannes Faltermeier <jfaltermeier@eclipsesource.com>
* update ElectronIpcConnectionProvider, ElectronMainApplicationContribution imports * update Theia versions Contributed on behalf of STMicroelectronics Signed-off-by: Johannes Faltermeier <jfaltermeier@eclipsesource.com>
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
The electron-chromedriver matches the electron version we are using. Mac Silicon (darwin-arm64) has only been supported since v11.0.0 and v9.0.0 build will fail. Fixes eclipse-theia/theia-blueprint#308
- Updates CDT cloud Blueprint to Theia Blueprint 1.45.1 (f037dcc) - Updates theia-traceviewer to 0.2.0 Contributed on behalf of STMicroelectronics Signed-off-by: Nina Doschek <ndoschek@eclipsesource.com>
Hi @sdirix , could you please have a look at the update PR? Thanks :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me!
However we are now consuming the rebranding of Blueprint to IDE, however in CDT Cloud we want to stay as Blueprint, so we need to check in each location whether we expose the IDE term to the user in some way.
I found some minor occurences which should be fixed.
theia-extensions/launcher/src/browser/create-launcher-contribution.ts
Outdated
Show resolved
Hide resolved
Thank you @sdirix for your review, I'll have a look today! |
@ndoschek Can you reword the commit with the ST attribution and remove the review wording? I will then merge as is |
@@ -29,7 +29,7 @@ export class CreateLauncherCommandContribution implements FrontendApplicationCon | |||
if (!initialized) { | |||
const messageContainer = document.createElement('div'); | |||
// eslint-disable-next-line max-len | |||
messageContainer.textContent = nls.localizeByDefault("Would you like to install a shell command that launches the application?\nYou will be able to run the Theia IDE from the command line by typing 'theia'."); | |||
messageContainer.textContent = nls.localizeByDefault("Would you like to install a shell command that launches the application?\nYou will be able to run Theia Blueprint from the command line by typing 'theia'."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be CDT Cloud Blueprint. We should also double check whether we actually install a "theia" command here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this the installation of the CLI launch command on my machine, and it is also theia
for our CDT Cloud blueprint app.
Contributed on behalf of STMicroelectronics Signed-off-by: Nina Doschek <ndoschek@eclipsesource.com>
30f06cc
to
d66477b
Compare
Thanks @sdirix, I addressed your comment and updated the commit message. |
What it does
Contributed on behalf of STMicroelectronics
Signed-off-by: Nina Doschek ndoschek@eclipsesource.com
Part of #83
How to test
yarn electron package:preview && yarn electron test
)