Merge CDT Cloud update to 1.45.1 #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Upgrade dependencies * Update jenkins job for windows to ensure that we download the correct version of node-gyp Contributed on behalf of STMicroelectronics
This may help to catch future errors
* update dependencies and versions * update builtins Contributed on behalf of STMicroelectronics
Contributed on behalf of STMicroelectronics Signed-off-by: Johannes Faltermeier <jfaltermeier@eclipsesource.com>
Contributed on behalf of STMicroelectronics Signed-off-by: Johannes Faltermeier <jfaltermeier@eclipsesource.com>
* add required plugins that are missing from the vscode-builtin-extensions-pack Contributed on behalf of STMicroelectronics Signed-off-by: Johannes Faltermeier <jfaltermeier@eclipsesource.com>
* rename nsis installer artifact to TheiaIDESetup.exe Contributed on behalf of STMicroelectronics Signed-off-by: Johannes Faltermeier <jfaltermeier@eclipsesource.com>
Contributed on behalf of STMicroelectronics Signed-off-by: Johannes Faltermeier <jfaltermeier@eclipsesource.com>
Contributed on behalf of STMicroelectronics Signed-off-by: Johannes Faltermeier <jfaltermeier@eclipsesource.com>
* update ElectronIpcConnectionProvider, ElectronMainApplicationContribution imports * update Theia versions Contributed on behalf of STMicroelectronics Signed-off-by: Johannes Faltermeier <jfaltermeier@eclipsesource.com>
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
The electron-chromedriver matches the electron version we are using. Mac Silicon (darwin-arm64) has only been supported since v11.0.0 and v9.0.0 build will fail. Fixes eclipse-theia/theia-blueprint#308
- Updates CDT cloud Blueprint to Theia Blueprint 1.45.1 (f037dcc) - Updates theia-traceviewer to 0.2.0 Contributed on behalf of STMicroelectronics Signed-off-by: Nina Doschek <ndoschek@eclipsesource.com>
13 tasks
|
Hi @sdirix , could you please have a look at the update PR? Thanks :) |
sdirix
requested changes
Mar 26, 2024
There was a problem hiding this comment.
Works for me!
However we are now consuming the rebranding of Blueprint to IDE, however in CDT Cloud we want to stay as Blueprint, so we need to check in each location whether we expose the IDE term to the user in some way.
I found some minor occurences which should be fixed.
theia-extensions/launcher/src/browser/create-launcher-contribution.ts
Outdated
Show resolved
Hide resolved
|
Thank you @sdirix for your review, I'll have a look today! |
|
@ndoschek Can you reword the commit with the ST attribution and remove the review wording? I will then merge as is |
sdirix
reviewed
Mar 28, 2024
| @@ -29,7 +29,7 @@ export class CreateLauncherCommandContribution implements FrontendApplicationCon | |||
| if (!initialized) { | |||
| const messageContainer = document.createElement('div'); | |||
| // eslint-disable-next-line max-len | |||
| messageContainer.textContent = nls.localizeByDefault("Would you like to install a shell command that launches the application?\nYou will be able to run the Theia IDE from the command line by typing 'theia'."); | |||
| messageContainer.textContent = nls.localizeByDefault("Would you like to install a shell command that launches the application?\nYou will be able to run Theia Blueprint from the command line by typing 'theia'."); | |||
There was a problem hiding this comment.
Should be CDT Cloud Blueprint. We should also double check whether we actually install a "theia" command here.
There was a problem hiding this comment.
I tested this the installation of the CLI launch command on my machine, and it is also theia for our CDT Cloud blueprint app.
Contributed on behalf of STMicroelectronics Signed-off-by: Nina Doschek <ndoschek@eclipsesource.com>
ndoschek
force-pushed
the
issues/83-update-theia1.45.1
branch
from
30f06cc
to
d66477b
Compare
|
Thanks @sdirix, I addressed your comment and updated the commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Contributed on behalf of STMicroelectronics
Signed-off-by: Nina Doschek ndoschek@eclipsesource.com
Part of #83
How to test
yarn electron package:preview && yarn electron test)