Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parenthesis cleanup & extra getFullPathExpression() calls #322

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Commits on Dec 6, 2023

  1. Casting Bug Test

    Add test to catch error when casting a variable to another type
    WyoTwT committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    2cec653 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. Remove parenthesis cleanup & extra getFullPathExpression() calls

    The total removal of parenthesis removes casting
    parenthesis and breaks potential watch expressions so
    this cleanup should be removed.
    Instead of calling getFullPathExpression() multiple times,
    build the fullPath from the topLevelExpression variable.
    In the case of Expressions, add encapsulating parenthesis
    to handle type casting properly.
    Update variable casting tests accordingly.
    WyoTwT committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    511b4e9 View commit details
    Browse the repository at this point in the history