Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider webpack again #17

Closed
dschaefer opened this issue Jan 16, 2019 · 1 comment
Closed

Consider webpack again #17

dschaefer opened this issue Jan 16, 2019 · 1 comment

Comments

@dschaefer
Copy link
Contributor

We will be using webpack to bundle the webview contents (React and stuff). Microsoft is really pushing to have extensions themselves also built with webpack. Here is a sample from their samples repo:

https://github.com/Microsoft/vscode-extension-samples/tree/master/webpack-sample

I think it makes sense to play along. It also allows us to have a single build process for all contents of the extension using webpack.

@dschaefer
Copy link
Contributor Author

We are now using webpack for the Memory Browser client side. I'm seeing some weird behavior in VS Code editing the project. Since we have to exclude the client source from the regular tsc build, the tsconfig.json has an exclude statement there. I looks like vscode picks that up and doesn't fully parse the client source, thus not picking up errors.

There are other ways to get around this than port everything to webpack so we can remove the exclude, of course.

@jonahgraham jonahgraham closed this as not planned Won't fix, can't repro, duplicate, stale Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants