Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making timeline-chart's height smaller adds a time axis in the middle of the graph #243

Closed
bhufmann opened this issue Jan 26, 2021 · 0 comments · Fixed by eclipse-cdt-cloud/timeline-chart#102
Closed

Making timeline-chart's height smaller adds a time axis in the middle of the graph #243

bhufmann opened this issue Jan 26, 2021 · 0 comments · Fixed by eclipse-cdt-cloud/timeline-chart#102
Labels
bug Something isn't working

Comments

@bhufmann
Copy link
Collaborator

bhufmann commented Jan 26, 2021 •
edited

Making timeline-chart's height smaller adds a time axis in the middle of the graph:

timeline-chart-resize-issue
@bhufmann bhufmann added the bug Something isn't working label Jan 26, 2021
@bhufmann bhufmann changed the title Making timeline-charts height small adds a time axis in the middle of the graph Making timeline-chart's height smaller adds a time axis in the middle of the graph Jan 26, 2021
@PatrickTasse PatrickTasse mentioned this issue Jan 27, 2021
Merged
PatrickTasse added a commit to eclipse-cdt-cloud/timeline-chart that referenced this issue Jan 27, 2021
@PatrickTasse
Make drawing of TimeGraphAxisScale labels optional and fix their y-pos
2da2641 
The y-pos of the text label should be just below the tick line height.

Drawing the labels should be optional and not done for a TimeGraphGrid
which only needs to draw tick (grid) lines at full height.

Fixes eclipse-cdt-cloud/theia-trace-extension#243
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make drawing of TimeGraphAxisScale labels optional and fix their y-pos PatrickTasse/timeline-chart
1 participant
@bhufmann