Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trees in XY or timeline charts chart are by strings by default #577

Closed
bhufmann opened this issue Nov 24, 2021 · 0 comments · Fixed by #578
Closed

Trees in XY or timeline charts chart are by strings by default #577

bhufmann opened this issue Nov 24, 2021 · 0 comments · Fixed by #578
Labels
bug Something isn't working Theia UI frontend

Comments

@bhufmann
Copy link
Collaborator

Some of the columns represent number values, however they are formatted on the server. For example, in the CPU usage view the
column % shows number + % and the Time column shows formatted time values with unit, e.g. 100 ms.

cpu-usage-sorting

Right now the cell content is provided as strings through the TSP and the formatting is done on the trace server. The TSP needs to be augmented to allow better sorting in either the front-end or the data is pre-sorted by the server based on a query parameter. This change is a full-stack change and starts with the TSP specification.

However, as stop-gap measure the front-end can try to parse the string and extract numbers for some know formats.
@bhufmann bhufmann added bug Something isn't working Theia UI frontend labels Nov 24, 2021
bhufmann added a commit to bhufmann/theia-trace-extension that referenced this issue Nov 24, 2021
@bhufmann
Provide front-end sorting of trees for based on the column
392414a 
Right now the sorting is done using string sorting. If the data in the
columns are numbers, then number sorting should be used. Moreover,
some known string formatting can be reversed to extract the number and
do a number comparison. For example, some data providers provide columns
with duration, where the value is formatted to show 'ns' for nanosecond,
'us' micro-second and so on. Other example, are percentages shown.

The tree of the CPU usage view when using the Trace Compass trace server
is good example for different columns and formatting.

Note that this implementation is a temporary solution until the TSP and
server back-end is augmented to provide a different mechanism to
support sorting.

fixes eclipse-cdt-cloud#577

Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
@bhufmann bhufmann mentioned this issue Nov 24, 2021
Merged
bhufmann added a commit to bhufmann/theia-trace-extension that referenced this issue Dec 2, 2021
@bhufmann
Provide front-end sorting of trees for based on the column
45a4dd0 
Right now the sorting is done using string sorting. If the data in the
columns are numbers, then number sorting should be used. Moreover,
some known string formatting can be reversed to extract the number and
do a number comparison. For example, some data providers provide columns
with duration, where the value is formatted to show 'ns' for nanosecond,
'us' micro-second and so on. Other example, are percentages shown.

The tree of the CPU usage view when using the Trace Compass trace server
is good example for different columns and formatting.

Note that this implementation is a temporary solution until the TSP and
server back-end is augmented to provide a different mechanism to
support sorting.

fixes eclipse-cdt-cloud#577

Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
bhufmann added a commit to bhufmann/theia-trace-extension that referenced this issue Dec 8, 2021
@bhufmann
Provide front-end sorting of trees for based on the column
ec5c1ed 
Right now the sorting is done using string sorting. If the data in the
columns are numbers, then number sorting should be used. Moreover,
some known string formatting can be reversed to extract the number and
do a number comparison. For example, some data providers provide columns
with duration, where the value is formatted to show 'ns' for nanosecond,
'us' micro-second and so on. Other example, are percentages shown.

The tree of the CPU usage view when using the Trace Compass trace server
is good example for different columns and formatting.

Note that this implementation is a temporary solution until the TSP and
server back-end is augmented to provide a different mechanism to
support sorting.

fixes eclipse-cdt-cloud#577

Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
bhufmann added a commit to bhufmann/theia-trace-extension that referenced this issue Dec 9, 2021
@bhufmann
Provide front-end sorting of trees for based on the column
6251e9e 
Right now the sorting is done using string sorting. If the data in the
columns are numbers, then number sorting should be used. Moreover,
some known string formatting can be reversed to extract the number and
do a number comparison. For example, some data providers provide columns
with duration, where the value is formatted to show 'ns' for nanosecond,
'us' micro-second and so on. Other example, are percentages shown.

The tree of the CPU usage view when using the Trace Compass trace server
is good example for different columns and formatting.

Note that this implementation is a temporary solution until the TSP and
server back-end is augmented to provide a different mechanism to
support sorting.

fixes eclipse-cdt-cloud#577

Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
bhufmann added a commit that referenced this issue Dec 9, 2021
@bhufmann
Provide front-end sorting of trees for based on the column
4641512 
Right now the sorting is done using string sorting. If the data in the
columns are numbers, then number sorting should be used. Moreover,
some known string formatting can be reversed to extract the number and
do a number comparison. For example, some data providers provide columns
with duration, where the value is formatted to show 'ns' for nanosecond,
'us' micro-second and so on. Other example, are percentages shown.

The tree of the CPU usage view when using the Trace Compass trace server
is good example for different columns and formatting.

Note that this implementation is a temporary solution until the TSP and
server back-end is augmented to provide a different mechanism to
support sorting.

fixes #577

Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Theia UI frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Provide front-end sorting of trees for based on the column bhufmann/theia-trace-extension
1 participant
@bhufmann