Table header tooltip #178
Draft
Table header tooltip #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to work 50% of the time... weird... |
tahini
reviewed
Nov 6, 2020
| width: this.props.columnWidth | ||
| width: this.props.columnWidth, | ||
| hide: hiddenColumn, | ||
| tooltipField: columnHeader.description |
There was a problem hiding this comment.
The javadoc of tooltipField says this: "The field where we get the tooltip on the object", it's not the tooltip itself. Maybe you could the tooltipValueGetter instead to return this text?
Use the "type" parameter to encode hidden columns. Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Use column description field Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
MatthewKhouzam
force-pushed
the
table-header-tooltip
branch
from
33b8005
to
4e378d9
Compare
|
@MatthewKhouzam would you want to continue with this proposal or close it? |
|
@MatthewKhouzam Is this PR still valid? |
|
@MatthewKhouzam what is the plan for this PR? |
dleclairbb
pushed a commit
to dleclairbb/theia-trace-extension
that referenced
this pull request
Oct 25, 2023
This helps get rid of some known security vulnerabilities. Also took care of a `yarn upgrade` warning, saying that devDependency `vsce` had been renamed to `@vscode/vsce`. Fixes eclipse-cdt-cloud#178 Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.