Set keyboard focus on graph/table when selecting an analysis #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrickTasse
requested changes
Jan 5, 2022
There was a problem hiding this comment.
When clicking on an output title, the focus is given to the whole output container. I think it should be given to the output's chart or table:
- for a timegraph or xy chart, so that we can then use WASD keys to zoom and pan
- for the event table so that we can use the arrow keys to navigate the table
hriday-panchasara
force-pushed
the
Issue/311-set-keyboard-focus-when-clicking-analysis
branch
2 times, most recently
from
2ce0635
to
2c26823
Compare
PatrickTasse
requested changes
Jan 17, 2022
packages/react-components/src/components/xy-output-component.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/src/components/datatree-output-component.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/src/components/datatree-output-component.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/src/components/table-output-component.tsx
Outdated
Show resolved
Hide resolved
hriday-panchasara
force-pushed
the
Issue/311-set-keyboard-focus-when-clicking-analysis
branch
from
c811c74
to
e650bb5
Compare
PatrickTasse
requested changes
Jan 18, 2022
packages/react-components/src/components/timegraph-output-component.tsx
Outdated
Show resolved
Hide resolved
hriday-panchasara
force-pushed
the
Issue/311-set-keyboard-focus-when-clicking-analysis
branch
from
02d7edb
to
186193e
Compare
PatrickTasse
requested changes
Jan 18, 2022
theia-extensions/viewer-prototype/src/browser/trace-viewer/trace-viewer.tsx
Show resolved
Hide resolved
hriday-panchasara
force-pushed
the
Issue/311-set-keyboard-focus-when-clicking-analysis
branch
2 times, most recently
from
f24404b
to
07704c9
Compare
hriday-panchasara
force-pushed
the
Issue/311-set-keyboard-focus-when-clicking-analysis
branch
2 times, most recently
from
683ddba
to
b76056b
Compare
PatrickTasse
previously approved these changes
Jan 21, 2022
packages/react-components/src/components/abstract-output-component.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/src/components/abstract-output-component.tsx
Outdated
Show resolved
Hide resolved
hriday-panchasara
force-pushed
the
Issue/311-set-keyboard-focus-when-clicking-analysis
branch
2 times, most recently
from
6a951bf
to
3b5aa41
Compare
PatrickTasse
previously approved these changes
Jan 25, 2022
bhufmann
requested review from
Rodrigoplp-work
and removed request for
bhufmann
|
@hriday-panchasara could you please rebase this PR? Then a final round of review can be done. Thanks |
hriday-panchasara
force-pushed
the
Issue/311-set-keyboard-focus-when-clicking-analysis
branch
from
3b5aa41
to
98126a1
Compare
fixes eclipse-cdt-cloud#414 When clicking on an analysis in the Available Analysis list, the analysis is scrolled into view and given keyboard focus. When clicking on an analysis title in the trace tab, keyboard focus should be the analysis' graph/chart region. If a View that is already open is selected in the sidebar, the View's title area should pulse to temporarily bring attention to the View panel. Signed-off-by: hriday-panchasara <hriday.panchasara@ericsson.com>
hriday-panchasara
force-pushed
the
Issue/311-set-keyboard-focus-when-clicking-analysis
branch
from
fa8b6ba
to
b6b635f
Compare
@bhufmann Rebased on top of master |
PatrickTasse
approved these changes
Feb 4, 2022
Rodrigoplp-work
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has changes for the following features suggested by @PatrickTasse in #311
When clicking on an analysis in the Available Analysis list, in the selected trace tab, the analysis is scrolled into view and given keyboard focus. User can click tab to access the tree and chart of the focused graph.
The trace tab should be scrolled to make that analysis visible, whether it is being opened for the first time or if it was already created previously.
When clicking on an analysis title in the trace tab, keyboard focus should be the analysis' graph/chart region. This is indicated by a blue focus border, allowing the user to directly use keyboard interactions/shortcuts
fixes #414
For some reason the focus outline is not being shown properly in some of the screen recordings. This is the default tab focus styling but we can change the css to make the outline more prominent.
Signed-off-by: hriday-panchasara hriday.panchasara@ericsson.com