Introduce tooltips to events table #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can be used to get raw time stamps and help with filters Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
MatthewKhouzam
force-pushed
the
tooltip-table
branch
from
69515ff
to
43ca42a
Compare
tahini
suggested changes
Oct 5, 2020
| $ref: '#/components/schemas/Query' | ||
| responses: | ||
| 200: | ||
| description: Returns a list of tooltip entries. The returned model must be consistent, parentIds must refer to a parent which exists in the model. |
There was a problem hiding this comment.
Do you have the concept of parent in the table?
There was a problem hiding this comment.
Also, could you define more precisely "tooltip entries"? The commit message says it can be used to retrieve raw data, but as an implementer of the protocol who reads this description and not the commit messages, I would never think of returning raw data here. Rather human-readable stuff
| schema: | ||
| type: string | ||
| requestBody: | ||
| description: Query parameters to fetch the timegraph tree. |
There was a problem hiding this comment.
Update description? Also, I don't think the parameters mentioned below apply to this query, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be used to get raw time stamps and help with filters
Signed-off-by: Matthew Khouzam matthew.khouzam@ericsson.com