New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Honor endianess on group level #88
Labels
bug
Something isn't working
Comments
1 task
martin-fleck-at
added a commit
to eclipsesource/vscode-memory-inspector
that referenced
this issue
Mar 5, 2024
- Move Endianness interface into common code - Add setting for 'Endianness' in package.json - Add option for 'Endianness' in options panel - Assume DAP as big endian and revert byte-order for little endian - Set 'Little Endian' as default as it may be more common Closes eclipse-cdt-cloud#88
1 task
martin-fleck-at
added a commit
to eclipsesource/vscode-memory-inspector
that referenced
this issue
Mar 6, 2024
- Move Endianness interface into common code - Add setting for 'Endianness' in package.json - Add option for 'Endianness' in options panel - Assume DAP as big endian and revert byte-order for little endian - Set 'Little Endian' as default as it may be more common Closes eclipse-cdt-cloud#88
jreineckearm
changed the title
Honor endianess on word level
Honor endianess on ~~word~~ group level
Mar 6, 2024
jreineckearm
changed the title
Honor endianess on ~~word~~ group level
Honor endianess on group level
Mar 6, 2024
martin-fleck-at
added a commit
to eclipsesource/vscode-memory-inspector
that referenced
this issue
Mar 7, 2024
- Move Endianness interface into common code - Add setting for 'Endianness' in package.json - Add option for 'Endianness' in options panel - Assume DAP as big endian and revert byte-order for little endian - Set 'Little Endian' as default as it may be more common Closes eclipse-cdt-cloud#88
martin-fleck-at
added a commit
to eclipsesource/vscode-memory-inspector
that referenced
this issue
Mar 8, 2024
- Move Endianness interface into common code - Add setting for 'Endianness' in package.json - Add option for 'Endianness' in options panel - Assume DAP as big endian and revert byte-order for little endian - Set 'Little Endian' as default as it may be more common Closes eclipse-cdt-cloud#88
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
The Memory Inspector internals do already have provisions to consider endianess in the display:
vscode-memory-inspector/src/webview/components/memory-widget.tsx
Line 43 in d1400a1
However, the corresponding property isn't honored yet for rendering. It should be on
word
group
level of the display. At the moment,wordsgroups appear to be displayed asbig endian
while the internal default islittle endian
.UPDATE (06/03/24): After further discussion between @martin-fleck-at and @jreineckearm , we agreed to change the scope for applying the endianess from
word
togroup
. The rational behind this was:groups
, notwords
. Applying endianess on aword
level would have been confusing because it would be hard to see when a new word starts. It is better to show groups in a consistent endianess scheme. To replicate a word endianess, the user can configure the display to use 1 word group.How to reproduce:
word
setting matches the type's size. And words per group is set to 1.variables
window and the displayed word in the Memory Inspector. Cheating a little below as the variable is shown in decimal representation:25000000 (decimal) = 0x017D7840
little
andbig
endianess to verify the byte-order is correctly swapped.Expected behavior
Expectation is that endianess is honored on
wordgroup level.Environment
Additional information
The text was updated successfully, but these errors were encountered: