-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support storing and applying of memory content #96
Merged
colin-grant-work
merged 7 commits into
eclipse-cdt-cloud:main
from
eclipsesource:issues/50
Mar 13, 2024
Merged
Support storing and applying of memory content #96
colin-grant-work
merged 7 commits into
eclipse-cdt-cloud:main
from
eclipsesource:issues/50
Mar 13, 2024
Commits on Mar 12, 2024
-
Support storing and applying of memory content
Add commands to store and apply memory content as Intel HEX file - Encapsulate behavior in new MemoryStorage class - Trigger 'store' from Memory view, Variables view and command palette - Trigger 'apply' from Memory view, Explorer view and command palette - Use nrf-intel-hex library for read/write file licensed under BSD-3 Use quick inputs to guide user through necessary input - Initialize as much of the input as possible through command args Communicate with webview through messenger requests and notifications -- Request to trigger store and apply from webview -- Notify webview about any written memory so it can update properly Minor improvements - Move some common types and functionality into 'common' area - Avoid bleeding Debug Adapter types into webview, use messaging types - Common style: 'getVariables' -> 'getVariablesType' - Provide utility functions and types for debug requests - Fix 'Enter' handling for numpad by checking key value of event Closes eclipse-cdt-cloud#50
Configuration menu - View commit details
-
Copy full SHA for 281c374 - Browse repository at this point
Copy the full SHA 281c374View commit details -
- Move evaluation expression for addressOf and sizeOf to adapter - Make 'toHexStringWithRadixMarker' more flexible - Shorten validation messages for memory - Align props and method names with existing method names, no prefixes - Replace 'MemoryVariableNode' with 'IVariablesContext' - Add comment on overlap calculation - Make sure command enablement fails early
Configuration menu - View commit details
-
Copy full SHA for 04b97a9 - Browse repository at this point
Copy the full SHA 04b97a9View commit details -
PR Feedback: Disable store/apply memory buttons if not possible
- VS Code always allows to execute a command programmatically -- There is no way to determine whether a command is enabled or not - Forward current session context to memory inspector
Configuration menu - View commit details
-
Copy full SHA for 53248da - Browse repository at this point
Copy the full SHA 53248daView commit details -
Further enhancements: Context menu, memory event, PR feedback
- Integrate commands with context menu - React to 'memory' event from debug adapter - Use 'Store Memory to File' as proper storage label - Use workspace folder as default save location - Minor fix for numpad key enter on memory options
Configuration menu - View commit details
-
Copy full SHA for 4b0c003 - Browse repository at this point
Copy the full SHA 4b0c003View commit details
Commits on Mar 13, 2024
-
- Use short (PascalCase) names for generic arguments - Adapt copyright header in debug-requests - Remove optional 'count' parameter in messaging and memory-provider - Remove caching of session context and simply re-create if necessary - Execute variable queries in parallel instead of sequentially - Fix typo in comment
Configuration menu - View commit details
-
Copy full SHA for 83c51b5 - Browse repository at this point
Copy the full SHA 83c51b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 175a330 - Browse repository at this point
Copy the full SHA 175a330View commit details -
Improve address handling and support decimal addresses
- Provide decimal address regex and function to extract address - Ensure we can properly serialize bigints when logging data - Ensure we return a proper variable range if we only have the address
Configuration menu - View commit details
-
Copy full SHA for edf986d - Browse repository at this point
Copy the full SHA edf986dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.