Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Node 18 #29

Closed
marcdumais-work opened this issue Feb 28, 2024 · 0 comments · Fixed by #30
Closed

Update to Node 18 #29

marcdumais-work opened this issue Feb 28, 2024 · 0 comments · Fixed by #30

Comments

@marcdumais-work
Copy link
Contributor

Node 16 end-of-life was last September 11th.

This repo will need a quick update, to use node 18 (currently 16.x). Potential references to node version:

  • GitHub workflows: add at least node 18 in the "matrix" (we may keep 16 for now).
  • package.json "engines.node" version ranges may need updating. e.g. ">=16 <=20 " could work for now
  • dockerfiles
  • documentation, e.g. README, guides
marcdumais-work added a commit that referenced this issue Feb 28, 2024
@marcdumais-work
update to node 18
3ade097 
Fixes #29

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
marcdumais-work added a commit that referenced this issue Feb 28, 2024
@marcdumais-work
update to node 18
89db1e5 
Fixes #29

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
@marcdumais-work marcdumais-work mentioned this issue Feb 28, 2024
Merged
marcdumais-work added a commit that referenced this issue Mar 7, 2024
@marcdumais-work
update to node 18
f725ee7 
Fixes #29

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
marcdumais-work added a commit that referenced this issue Mar 8, 2024
@marcdumais-work
update to node 18
5913235 
Fixes #29

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update to node 18 eclipse-cdt-cloud/vscode-trace-server
1 participant
@marcdumais-work